Conversation
What is the motivation for this PR? In acl stress test, ACL table creation can be failed on dualtor platform because of insufficient resources The test case only add/delete a same rule, which is not the real scenario in production How did you do it? Support dualtor platform Add/delete 100 acl rules Use sonic-cfggen to add acl table and rule to config db, will reduce test time Use loganalyzer to check add/delete status How did you verify/test it? Run testcase Any platform specific information? Supported testbed topology if it's a new test case?
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
|
@abdosi - Can we cherry pick this PR into 202205 branch. I am not able to edit the description to add the include the 202205 label. |
* Improve acl stress test What is the motivation for this PR? In acl stress test, ACL table creation can be failed on dualtor platform because of insufficient resources The test case only add/delete a same rule, which is not the real scenario in production How did you do it? Support dualtor platform Add/delete 100 acl rules Use sonic-cfggen to add acl table and rule to config db, will reduce test time Use loganalyzer to check add/delete status Use nohup to run bash script, avoid ssh overtime How did you verify/test it? Run testcase Any platform specific information? Supported testbed topology if it's a new test case?
* Improve acl stress test What is the motivation for this PR? In acl stress test, ACL table creation can be failed on dualtor platform because of insufficient resources The test case only add/delete a same rule, which is not the real scenario in production How did you do it? Support dualtor platform Add/delete 100 acl rules Use sonic-cfggen to add acl table and rule to config db, will reduce test time Use loganalyzer to check add/delete status Use nohup to run bash script, avoid ssh overtime How did you verify/test it? Run testcase Any platform specific information? Supported testbed topology if it's a new test case?
creation In `acl/test_stress_acl.py`, it attempts to retrieve an interface that can be used to create a ACL table. DUTs with and without PortChannels require different methods respectively. Currently, it checks by filtering with topo. However, some topology flags can have configurations that have or not have PortChannels, making topos no longer a sufficient check. Fix by checking if a PortChannel exists. If it does - use it. If it does not - fallback on the secondary method to retrieve a normal interface name if its a not a dualtor topo (due to sonic-net#6960).
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In acl stress test, ACL table creation can be failed on dualtor platform because of insufficient resources
The test case only add/delete a same rule, which is not the real scenario in production
How did you do it?
How did you verify/test it?
Run testcase
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation