Skip to content

[dhcp_server] Skip dhcp_relay check in pretest if dhcp_server is enabled #6956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Blueve merged 2 commits into from
Dec 6, 2022
Merged

[dhcp_server] Skip dhcp_relay check in pretest if dhcp_server is enabled #6956

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dcc9b4
[dhcp_server] Skip dhcp_relay check in pretest if dhcp_server is enabled
yaqiangz Dec 5, 2022
faef07c
Fix comments
yaqiangz Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/test_pretest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,14 @@ def test_disable_rsyslog_rate_limit(duthosts, enum_dut_hostname):
# We don't want to fail here because it's an util
logging.warn("Failed to retrieve feature status")
return
config_facts = duthost.config_facts(host=duthost.hostname, source="running")
is_dhcp_server_enable = config_facts["ansible_facts"]["DEVICE_METADATA"]["localhost"]["dhcp_server"]
for feature_name, state in features_dict.items():
if 'enabled' not in state:
continue
# Skip dhcp_relay check if dhcp_server is enabled
if "enabled" in is_dhcp_server_enable and feature_name == "dhcp_relay":
continue
duthost.modify_syslog_rate_limit(feature_name, rl_option='disable')


Expand Down