Skip to content

Add new test case test_separated_qos_map_on_tor#6949

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:separated_qos_map_tor
Dec 7, 2022
Merged

Add new test case test_separated_qos_map_on_tor#6949
bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms:separated_qos_map_tor

Conversation

@bingwang-ms
Copy link
Copy Markdown
Collaborator

Description of PR

Summary:
This PR is to check in a new test case test_separated_qos_map_on_tor.
From PR sonic-net/sonic-buildimage#12730, sepatared QoS map are applied to uplink/downlink ports on dualtor.
The test case is to verify separated DSCP_TO_TC_MAP/TC_TO_QUEUE_MAP on uplink and downlink ports of dualtor
Test steps

  1. Build IPinIP encapsulated packet with dummy src ip and dst ip (must not be the loopback address of dualtor)
  2. Ingress the packet from uplink port, verify the packets egressed from expected queue
  3. Build regular packet with dst_ip = dummy IP (routed by default route)
  4. Ingress the packet from downlink port, verify the packets egressed from expected queue

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

This PR is to check in a new test case test_separated_qos_map_on_tor.

How did you do it?

How did you verify/test it?

Verified on a dualtor testbed

collected 1 item                                                                                                                                                                                                                                               
qos/test_tunnel_qos_remap.py::test_separated_qos_map_on_tor PASSED                                                                                                                                                                                       [100%]
============================================================================================================ 1 passed, 2 warnings in 264.63 seconds ============================================================================================================

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

Dualtor topo specific.

Documentation

@azure-pipelines
Copy link
Copy Markdown

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Failed
- hook id: trailing-whitespace
- exit code: 1
- files were modified by this hook

Fixing tests/qos/test_tunnel_qos_remap.py
Fixing tests/qos/tunnel_qos_remap_base.py

fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/qos/test_tunnel_qos_remap.py:6:1: F401 'tests.common.fixtures.ptfhost_utils.copy_ptftests_directory' imported but unused
tests/qos/test_tunnel_qos_remap.py:7:1: F401 'tests.common.fixtures.ptfhost_utils.copy_saitests_directory' imported but unused
tests/qos/test_tunnel_qos_remap.py:8:1: F401 'tests.common.fixtures.ptfhost_utils.change_mac_addresses' imported but unused
tests/qos/test_tunnel_qos_remap.py:9:1: F401 'tests.common.fixtures.ptfhost_utils.run_icmp_responder' imported but unused
...
[truncated extra lines, please run pre-commit locally to view full check results]

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants