Everflow for Chassis/T2 topology#6945
Conversation
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Nethop-Group/ECMP Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
releases. Current logic is for v4 TCP flow. v6 TCP flow will be added later. Also fixed LGTM Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
present in IPv6 header Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
@sanmalho-git please take this PR and have another PR on top of it for VOQ Chassis. With this PR Everflow is passing for non-VOQ Chassis/T2 topology. |
|
@vperumal Please start using this PR. |
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
@bingwang-ms please help review this. Let me know if you have any questions. As this PR has lot of changes so it will be great if we can review/approve soon to avoid merge conflict. |
| test_mirror_v4 = switch_capabilities["MIRROR"] == "true" | ||
| test_mirror_v6 = switch_capabilities["MIRRORV6"] == "true" | ||
| test_mirror_v4 = upstream_switch_capabilities["MIRROR"] == "true" and downstream_switch_capabilities["MIRROR"] == "true" | ||
| test_mirror_v6 = upstream_switch_capabilities["MIRRORV6"] == "true" and downstream_switch_capabilities["MIRRORV6"] == "true" |
There was a problem hiding this comment.
Can you please clarify why do we care about the upstream and downstream switch capabilities? For T0 device, what's the downstream_switch_capabilities["MIRROR"] ?
There was a problem hiding this comment.
for T0 upStream and downStream Dut are same so both point to same capabilities. This is just to keep code geneic and not have if..else
|
Please also verify this change in T0 and T1 testbed. Thanks @bingwang-ms Have verified on both T0 and T1 testbed also. |
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
@bingwang-ms Have address all of your comments. please check. |
|
@bingwang-ms can you please check and approve |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Enhance test_default_route.py for chassis. How I did: Concept of selecting upstream duthost and verify test case on that Depends on this PR Everflow for Chassis/T2 topology #6945 for common utility function. Some of Core Router even though T3 we might not expect Default Route based on Device Type.
Enable Everflow test case infrastructure to work for T2/Multi-Dut topology
Enhance test_default_route.py for chassis. How I did: Concept of selecting upstream duthost and verify test case on that Depends on this PR Everflow for Chassis/T2 topology #6945 for common utility function. Some of Core Router even though T3 we might not expect Default Route based on Device Type.
4 participants
What I did:
Enable Eveflow test case infrastructure to work for T2/Multi-Dut topology
How I did:
This PR takes some of the changes from the PR: #6958 and build on top of it.
Here is the summary of the infrastructure changes:
everflow_dutandremote_dutper everflow monitor port direction. Everflow Dut represents entity where given flow will ingress and get mirrored out. Remote Dut represents entity where the Mirror session IP is directly reachable via static routeupstream dutanddownstream dutwhich will be same for Single Dut Scenario and 2 different for chassis use case. This two dut will be mapped aseverflow_dutandremote_dutingress_router_macandegress_router_macper everflow monitor port direction. This is needed as each ASIC,LC in case ofchassis-packetcan have differeent router-macsetup_infofixture.show mirror_sessionfor getting monitor port. Monitor port will always from come fromsetup_infoHow I verify:
Manually Verified on both T0, T1 topology and T2 (
chassis-packet) topology