Remove test_tor_ecn from xfail condition mark#6939
Merged
StormLiangMS merged 2 commits intosonic-net:202205from Dec 11, 2022
Merged
Remove test_tor_ecn from xfail condition mark#6939StormLiangMS merged 2 commits intosonic-net:202205from
StormLiangMS merged 2 commits intosonic-net:202205from
Conversation
Signed-off-by: Zhaohui Sun <[email protected]>
XuChen-MSFT
reviewed
Dec 2, 2022
Contributor
XuChen-MSFT
left a comment
XuChen-MSFT
left a comment
There was a problem hiding this comment.
Can we set "skip" action for non-real dual tor? don't run ecn test for single tor and emulated dual tor.
Contributor
Author
@XuChen-MSFT test_tor_ecn will not run signal tor, since it defines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhaohui Sun [email protected]
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
What is the motivation for this PR?
In #6906, it fixed test_tor_ecn failures.
No need to xfail it.
How did you do it?
Remove test_tor_ecn from xfail condition mark
How did you verify/test it?
Run dualtor/test_tor_ecn.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation