Skip to content

Skip watchdog reboot for Supervisor in Cisco 8000 distributed chassis #6812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vperumal wants to merge 1 commit into from
Closed

Skip watchdog reboot for Supervisor in Cisco 8000 distributed chassis #6812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/platform_tests/test_reboot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,8 @@ def test_watchdog_reboot(duthosts, enum_rand_one_per_hwsku_hostname, localhost,
"""
duthost = duthosts[enum_rand_one_per_hwsku_hostname]

if duthost.is_supervisor_node and duthost.facts['platform'] in ['x86_64-8800_rp_o-r0']:
Copy link
Copy Markdown
Contributor

@gechiang gechiang Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vperumal
Instead of adding a skip here for a specific HW SKU, can this be changed in the Cisco platform code on the handling of "sudo watchdogutil status" to error out or produce no output so that the test is naturally skipped with existing code?
When Cisco is ready to handle it, then you can change your code to respond with proper response and we do not need to change this test code again?
Have you considered this approach instead?

Copy link
Copy Markdown
Contributor

@abdosi abdosi Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vperumal any comment ?

pytest.skip("Skip watchdog reboot for Supervisor card in Cisco 8000 distributed chassis")
watchdogutil_status_result = duthost.command("watchdogutil status", module_ignore_errors=True)
if "" != watchdogutil_status_result["stderr"] or "" == watchdogutil_status_result["stdout"]:
pytest.skip("Watchdog is not supported on this DUT, skip this test case")
Expand Down