[snmp] Add snmp_facts support for ieee802.1ab MIBs, extend snmp testcase#679
[snmp] Add snmp_facts support for ieee802.1ab MIBs, extend snmp testcase#679qiluo-msft merged 3 commits intosonic-net:masterfrom
Conversation
|
I am interested whether you have did integration test with any management tool. Just curious. #Closed |
|
|
||
| - name: "Verify {{ item }} is defined" | ||
| assert: { that: "{{ snmp_lldp[item] is defined }} | ||
| and not {{ snmp_lldp[item] | search('No Such Object currently exists') }}" } |
There was a problem hiding this comment.
Add one level indentation before 'and not'? #Closed
| # Check if lldpLocManAddr is present | ||
| - name: "Verify {{ item }} is defined" | ||
| assert: { that: "{{ snmp_lldp[item] is defined }} | ||
| and not {{ snmp_lldp[item] | search('No Such Object currently exists') }}" } |
| - fail: | ||
| msg: "lldpLocPortTable data missing for interface {{ item.key }}" | ||
| when: "{{ item.value.description | match('^Ethernet') }} | ||
| and ( {{ item.value['lldpLocPortNum'] is not defined }} |
| with_dict: minigraph_neighbors | ||
|
|
||
| - name: Create list of ports with lldpRemTable data | ||
| when: "{{ item.value['lldpRemTimeMark'] is defined }} |
|
|
||
| - name: Create list of ports with lldpRemManAddr data | ||
| when: "{{ item.value['lldpRemManAddrSubtype'] is defined }} | ||
| and {{ item.value['lldpRemManAddr'] is defined }} |
|
|
||
| - debug: | ||
| msg: "Found {{ active_intf | length }} Ifs with lldpRemManAddr data\n | ||
| Minigraph contains {{ minigraph_lldp_nei | length }} neighbors" |
| msg: "Found {{ active_intf | length }} Ifs with lldpRemManAddr data\n | ||
| Minigraph contains {{ minigraph_lldp_nei | length }} neighbors" | ||
|
|
||
| - name: Verify lldpRemManAddr is available on most interfaces |
There was a problem hiding this comment.
Should we test lldpRemManAddr is available on all interfaces? #Closed
There was a problem hiding this comment.
Taking into consideration that in lldp test we are satisfied with lldp data awailable on 80% of the interfaces, demanding more of the same data here is questionable.
https://github.com/Azure/sonic-mgmt/blob/master/ansible/roles/test/tasks/lldp.yml#L25
I think the intent was to prevent failures caused by testbed troubles - some VMs being down/not sending lldp...
|
In progress of integrating with Mellanox NEO. Do you use any management software with your testbed? #Resolved |
|
We don't have one. In reply to: 413484821 [](ancestors = 413484821) |
|
It will break the nightly test of old images. Could you add some logic to bypass the test? |
…mp testcase (sonic-net#679)" This reverts commit 2faebb7.
Update sonic-swss-common submodule pointer to include the following: * VxLAN Tunnel Counters and Rates implementation (sonic-net#519) ([sonic-net#679](sonic-net/sonic-swss-common#679))
3 participants
Description of PR
Summary:
Fixes # (issue)
Subtest logic :
❗WARNING❗ :
make sure submodule is updated before merging this one
sonic-net/sonic-buildimage#1930 (already merged)
Type of change
Approach
How did you do it?
How did you verify/test it?
Run snmp test
Any platform specific information?
Supported testbed topology if it's a new test case?
Should work on any topology. Tested on t0, t1, t1-lag
Documentation