Add dualtor support for directed broadcast test#6395
Merged
xwjiang-ms merged 7 commits intosonic-net:masterfrom Sep 30, 2022
Merged
Add dualtor support for directed broadcast test#6395xwjiang-ms merged 7 commits intosonic-net:masterfrom
xwjiang-ms merged 7 commits intosonic-net:masterfrom
Conversation
What is the motivation for this PR? Directed bcast test only support t0 topo, but dualtor also support this function How did you do it? 1. Use mgfacts to get src/dst ports instead of hard code 2. Use json file to record src/dst ports 3. Dualtor will forward dir bcast packets from active ports, so after toggling, dst ports should be all active ports in "show mux status" How did you verify/test it? Run test Any platform specific information? Supported testbed topology if it's a new test case?
|
This pull request introduces 3 alerts when merging 877e47d into e22a588 - view on LGTM.com new alerts:
|
Contributor
Author
|
Dualtor don't support directed broadcast, so use xfail now, created an issue: sonic-net/sonic-buildimage#12167 |
wangxin
reviewed
Sep 27, 2022
tests/ipfwd/test_dir_bcast.py
Outdated
| ptfhost.copy(content=json.dumps(ptf_test_port_map), dest=PTF_TEST_PORT_MAP) | ||
|
|
||
|
|
||
| @pytest.mark.xfail |
Collaborator
There was a problem hiding this comment.
Please add the xfail mark to conditional mark yaml file.
Currently, dir_bcast only fails on dualtor. It should be able to pass on other topologies.
wangxin
reviewed
Sep 27, 2022
tests/ipfwd/test_dir_bcast.py
Outdated
|
|
||
| PTF_TEST_PORT_MAP = '/root/ptf_test_port_map.json' | ||
|
|
||
| def parse_mux_status(output_lines): |
Collaborator
There was a problem hiding this comment.
Can you take advantage of the existing show_and_parse method to avoid code duplication: https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/devices/sonic.py#L1387
Contributor
Author
There was a problem hiding this comment.
Sure, that will be better
Collaborator
|
@xwjiang-ms Can you also resolve the merge conflicts? |
Contributor
Author
OK, I will solve it |
1. Record vlan ip port pair in json file in case multi vlan 2. Use "show_and_parse" to parse duthost output 3. Do not skip dualtor but xfail in conditional mark
wangxin
reviewed
Sep 30, 2022
| - "topo_type not in ['t0', 'm0', 'dualtor']" | ||
|
|
||
| ipfwd/test_dir_bcast.py: | ||
| xfail: |
Collaborator
There was a problem hiding this comment.
The xfail mark need to be specified under the same ipfwd/test_dir_bcast.py entry. Otherwise, we will have duplicated entries in this yaml file.
Contributor
Author
There was a problem hiding this comment.
OK, I will change it
… Otherwise, in case have duplicated entries in this yaml file.
…/sonic-mgmt into dir_bcast_for_dualtor
wangxin
reviewed
Sep 30, 2022
wangxin
approved these changes
Sep 30, 2022
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 17, 2022
* Add dualtor support for directed bcast test What is the motivation for this PR? Directed bcast test only support t0 topo, but dualtor also support this function How did you do it? 1. Use mgfacts to get src ports instead of hard code 2. Use json file to record src ports, vlan prefix and dst ports parir 3. Dualtor will forward dir bcast packets from active ports, so after toggling, dst ports should be all active ports in "show mux status" 4. Do not skip dualtor but xfail in conditional mark How did you verify/test it? Run test Any platform specific information? Supported testbed topology if it's a new test case?
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
* Add dualtor support for directed bcast test What is the motivation for this PR? Directed bcast test only support t0 topo, but dualtor also support this function How did you do it? 1. Use mgfacts to get src ports instead of hard code 2. Use json file to record src ports, vlan prefix and dst ports parir 3. Dualtor will forward dir bcast packets from active ports, so after toggling, dst ports should be all active ports in "show mux status" 4. Do not skip dualtor but xfail in conditional mark How did you verify/test it? Run test Any platform specific information? Supported testbed topology if it's a new test case?
wangxin
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Add dualtor support for directed bcast test What is the motivation for this PR? Directed bcast test only support t0 topo, but dualtor also support this function How did you do it? 1. Use mgfacts to get src ports instead of hard code 2. Use json file to record src ports, vlan prefix and dst ports parir 3. Dualtor will forward dir bcast packets from active ports, so after toggling, dst ports should be all active ports in "show mux status" 4. Do not skip dualtor but xfail in conditional mark How did you verify/test it? Run test Any platform specific information? Supported testbed topology if it's a new test case?
6 tasks
wangxin
pushed a commit
to xwjiang-ms/sonic-mgmt
that referenced
this pull request
May 31, 2023
What is the motivation for this PR? dir_bcast test always fails in t0-56 topo How did you do it? Add topo support and sync with master branch ref PR: sonic-net#6395
xwjiang-ms
added a commit
that referenced
this pull request
May 31, 2023
* [202012]Fix dir bcast failure in to-56 topo What is the motivation for this PR? dir_bcast test always fails in t0-56 topo How did you do it? Add topo support and sync with master branch ref PR: #6395
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Directed bcast test only support t0 topo, but dualtor also support this function
How did you do it?
How did you verify/test it?
Run test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation