[test_bfd_multihop] add missing import of fixture#6382
Merged
siqbal1986 merged 1 commit intosonic-net:masterfrom Oct 17, 2022
Merged
[test_bfd_multihop] add missing import of fixture#6382siqbal1986 merged 1 commit intosonic-net:masterfrom
siqbal1986 merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Anton <[email protected]>
nhe-NV
approved these changes
Sep 21, 2022
Contributor
Author
|
@siqbal1986 FYI |
|
This pull request introduces 1 alert when merging 848d15c into 9074e57 - view on LGTM.com new alerts:
|
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 6382 in repo sonic-net/sonic-mgmt |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Sep 30, 2022
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
Signed-off-by: Anton <[email protected]>
wangxin
pushed a commit
that referenced
this pull request
Mar 31, 2023
Signed-off-by: Anton <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anton [email protected]
Description of PR
Summary:
In PR #6032 mistake was introduced.
No import for the fixture.
As a result, the bfd_multihop test failed with error:
@pytest.mark.parametrize('ipv6', [False, True], ids=['ipv4', 'ipv6'])
def test_bfd_multihop(request, rand_selected_dut, ptfhost, tbinfo, toggle_all_simulator_ports_to_rand_selected_tor_m, ipv6):
E fixture 'toggle_all_simulator_ports_to_rand_selected_tor_m' not found
Added missed import of fixture.
Type of change
Back port request
Approach
What is the motivation for this PR?
Stabilize the test
How did you do it?
Added missed import of fixture.
How did you verify/test it?
Test executed and passed
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation