Skip to content

Don't add dhcp rules for multiasic testbed#6165

Closed
ZhaohuiS wants to merge 1 commit intosonic-net:masterfrom
ZhaohuiS:fix/test_multiasic_cacl_application
Closed

Don't add dhcp rules for multiasic testbed#6165
ZhaohuiS wants to merge 1 commit intosonic-net:masterfrom
ZhaohuiS:fix/test_multiasic_cacl_application

Conversation

@ZhaohuiS
Copy link
Contributor

@ZhaohuiS ZhaohuiS commented Aug 15, 2022

Signed-off-by: Zhaohui Sun zhaohuisun@microsoft.com

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

test_multiasic_cacl_application failed at adding dhcp rules in generate_expected_rules.

How did you do it?

Add a check, if it's multiasic, will not call iptables_rules.extend(expected_dhcp_rules_for_standby).

How did you verify/test it?

run cacl/test_cacl_application.py::test_multiasic_cacl_application

cacl/test_cacl_application.py::test_multiasic_cacl_application[0] PASSED                                                                                                                                       [ 44%]
cacl/test_cacl_application.py::test_multiasic_cacl_application[1] PASSED                                                                                                                                       [ 55%]
cacl/test_cacl_application.py::test_multiasic_cacl_application[2] PASSED                                                                                                                                       [ 66%]
cacl/test_cacl_application.py::test_multiasic_cacl_application[3] PASSED

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
@ZhaohuiS
Copy link
Contributor Author

The issue was fixed in this PR #6170.
Close this one.

@ZhaohuiS ZhaohuiS closed this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant