Skip to content

[SFP][test_get_transceiver_info] | fix test issue "Transceiver info got by sfp api contains unexpected fields"#6114

Merged
prgeor merged 1 commit intosonic-net:masterfrom
nhe-NV:fix_qsfp_xcvr_info_issue
Aug 29, 2022
Merged

[SFP][test_get_transceiver_info] | fix test issue "Transceiver info got by sfp api contains unexpected fields"#6114
prgeor merged 1 commit intosonic-net:masterfrom
nhe-NV:fix_qsfp_xcvr_info_issue

Conversation

@nhe-NV
Copy link
Contributor

@nhe-NV nhe-NV commented Aug 8, 2022

For the QSFP-DD cable, there are some new added keys in the xcvr info in 202205 or later, so align the script

Change-Id: I50301ffde78e029137914ef511f442de032619ec

Description of PR

Summary: For the QSFP-DD cable, there are some new added keys in the xcvr info in 202205 or later, so align the script
Fixes # (issue) fix test issue "Transceiver info got by sfp api contains unexpected fields"

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

fix test issue "Transceiver info got by sfp api contains unexpected fields"

How did you do it?

Add the new added keys after 202205 to the test script.

How did you verify/test it?

Run the test_get_transceiver_info on 202205, and it pass

Any platform specific information?

No

Supported testbed topology if it's a new test case?

Documentation

@nhe-NV nhe-NV requested a review from sujinmkang as a code owner August 8, 2022 08:21
@nhe-NV
Copy link
Contributor Author

nhe-NV commented Aug 9, 2022

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

AntonHryshchuk
AntonHryshchuk previously approved these changes Aug 9, 2022
…ntains unexpected fields

For the QSFP-DD, there are some new added keys in the xcvr info in 202205 or later, so align the script

Change-Id: I50301ffde78e029137914ef511f442de032619ec

Change-Id: If9005572259cab0b3f092aa20d053a96c2d537d5
@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-mgmt

@liat-grozovik
Copy link
Collaborator

@prgeor fyi

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prgeor prgeor merged commit 6ef32a1 into sonic-net:master Aug 29, 2022
@prgeor
Copy link
Contributor

prgeor commented Aug 29, 2022

@yxieca can this be cherry-picked to 202205? i didin't find the right label

allen-xf pushed a commit to allen-xf/sonic-mgmt that referenced this pull request Oct 28, 2022
…ntains unexpected fields (sonic-net#6114)

For the QSFP-DD, there are some new added keys in the xcvr info in 202205 or later, so align the script

Change-Id: I50301ffde78e029137914ef511f442de032619ec

Change-Id: If9005572259cab0b3f092aa20d053a96c2d537d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants