Skip to content

[auto-ts] Fix and stabilize auto-techsupport tests #5986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhaohuiS merged 3 commits into from
Jul 25, 2022
Merged

[auto-ts] Fix and stabilize auto-techsupport tests #5986

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ee1a9c
[auto-ts] Fix and stabilize auto-techsupport tests
AndriiLozovyi Jul 15, 2022
b5a9ce4
Merge branch 'master' into fix_and_stabilize_auto_ts
AndriiLozovyi Jul 22, 2022
9b98182
Update test_auto_techsupport.py
AndriiLozovyi Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions tests/show_techsupport/test_auto_techsupport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def cleanup(cleanup_list):
func(*args, **kwargs)


@pytest.fixture(autouse=True)
@pytest.fixture()
def cleanup_list():
"""
Fixture to execute cleanup after test run
Expand Down Expand Up @@ -319,14 +319,16 @@ def test_rate_limit_interval(self, cleanup_list):
validate_auto_techsupport_global_config(self.dut_cli, rate_limit_interval=rate_limit_30)

with allure.step('Create .core files in test docker: {}'.format(self.test_docker)):
available_tech_support_files = get_available_tech_support_files(self.duthost)
trigger_auto_techsupport(self.duthost, self.test_docker)

with allure.step('Create .core files in all available dockers'):
for docker in self.dockers_list:
trigger_auto_techsupport(self.duthost, docker)

with allure.step('Checking that only 1 techsupport process running'):
validate_techsupport_generation(self.duthost, self.dut_cli, is_techsupport_expected=True)
validate_techsupport_generation(self.duthost, self.dut_cli, is_techsupport_expected=True,
available_tech_support_files=available_tech_support_files)

logger.info('Sleep until {} second pass since techsupport file created'.format(rate_limit_30))
time.sleep(rate_limit_30)
Expand All @@ -341,14 +343,16 @@ def test_rate_limit_interval(self, cleanup_list):
time.sleep(rate_limit_60 - rate_limit_30)

with allure.step('Create .core files in test docker: {}'.format(self.test_docker)):
available_tech_support_files = get_available_tech_support_files(self.duthost)
trigger_auto_techsupport(self.duthost, self.test_docker)

with allure.step('Create .core files in all available dockers'):
for docker in self.dockers_list:
trigger_auto_techsupport(self.duthost, docker)

with allure.step('Checking that only 1 techsupport process running'):
validate_techsupport_generation(self.duthost, self.dut_cli, is_techsupport_expected=True)
validate_techsupport_generation(self.duthost, self.dut_cli, is_techsupport_expected=True,
available_tech_support_files=available_tech_support_files)

@pytest.mark.parametrize('test_mode', max_limit_test_modes_list)
def test_max_limit(self, test_mode, global_rate_limit_zero, feature_rate_limit_zero, cleanup_list):
Expand Down Expand Up @@ -750,8 +754,9 @@ def validate_auto_techsupport_feature_config(dut_cli, expected_status_dict=None)
'Wrong configuration rate_limit_interval: {} for: {}'.format(rate_limit_interval, feature)



def validate_techsupport_generation(duthost, dut_cli, is_techsupport_expected, expected_core_file=None,
since_value_in_seconds=None):
since_value_in_seconds=None, available_tech_support_files=None):
"""
Validated techsupport generation. Check if techsupport started or not. Check number of files created.
Check history, check mapping between core files and techsupport files.
Expand All @@ -767,10 +772,8 @@ def validate_techsupport_generation(duthost, dut_cli, is_techsupport_expected, e
expected_oldest_log_line_timestamps_list = get_expected_oldest_timestamp_datetime(duthost,
since_value_in_seconds)

try:
available_tech_support_files = duthost.shell('ls /var/dump/*.tar.gz')['stdout_lines']
except RunAnsibleModuleFail:
available_tech_support_files = []
if not available_tech_support_files:
available_tech_support_files = get_available_tech_support_files(duthost)

if is_techsupport_expected:
expected_techsupport_files = True
Expand Down Expand Up @@ -1119,3 +1122,11 @@ def clear_folders(duthost):
def create_core_file_generator_script(duthost):
duthost.shell('sudo echo \'sleep 10 & kill -6 $!\' > /etc/sonic/core_file_generator.sh')
duthost.shell('sudo echo \'echo $?\' >> /etc/sonic/core_file_generator.sh')


def get_available_tech_support_files(duthost):
try:
available_tech_support_files = duthost.shell('ls /var/dump/*.tar.gz')['stdout_lines']
except RunAnsibleModuleFail:
available_tech_support_files = []
return available_tech_support_files