[auto-ts] Updated regex in test_auto_techsupport#5924
Merged
ZhaohuiS merged 3 commits intosonic-net:masterfrom Jul 17, 2022
Merged
[auto-ts] Updated regex in test_auto_techsupport#5924ZhaohuiS merged 3 commits intosonic-net:masterfrom
ZhaohuiS merged 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Andrii-Yosafat Lozovyi <andrii-yosafatx.lozovyi@intel.com>
Contributor
Author
|
@ZhaohuiS Could you please take a look? |
ZhaohuiS
reviewed
Jul 15, 2022
| result_dict = {'state': state, 'rate_limit_interval': rate_limit_interval, | ||
| 'max_techsupport_limit': max_techsupport_limit, 'max_core_size': max_core_size, 'since': since} | ||
| 'max_techsupport_limit': max_techsupport_limit, 'max_core_size': max_core_size, | ||
| 'available_mem_thresh': available_mem_thresh, 'min_available_mem': min_available_mem, 'since': since} |
Contributor
There was a problem hiding this comment.
@AndriiLozovyi If the command is changed again, we have to rewrite this function one more time. Could you please check if it's possible to call show_and_parse, doc is here
Contributor
Author
There was a problem hiding this comment.
@ZhaohuiS
Good suggestion, reworked to use show_and_parse instead of regex
Signed-off-by: Andrii-Yosafat Lozovyi <andrii-yosafatx.lozovyi@intel.com>
|
This pull request introduces 1 alert when merging 26135fa into f7bde1e - view on LGTM.com new alerts:
|
ZhaohuiS
approved these changes
Jul 17, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrii-Yosafat Lozovyi andrii-yosafatx.lozovyi@intel.com
Description of PR
Summary:
In PR - 10433 were added changes that add automatic techsupport invocation in case memory usage is too high. After this PR output of Cli cmd's
(show auto-techsupport global, show auto-techsupport-feature, show auto-techsupport history)changed and TC's are failing to parse the output on SONiC imagesSONiC.master.112803-dirty-20220621.160636or higher .This PR updates the regex to properly parse the output in both cases (when TC will run on Sonic image that doesn't include changes in 10433 or in case when Sonic image have this changes
SONiC.master.112803-dirty-20220621.160636or higher)Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Update the regex to properly parse the output of cli cmd's on newer SONiC images
How did you do it?
How did you verify/test it?
Run TC on Sonic image
SONiC.master.112803-dirty-20220621.160636andSONiC.master.105614-dirty-20220602.215204Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation