Skip to content

[conditional mark] To add test_thermal_control_load_invalid_value_json skip for Cisco.#5875

Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom
StormLiangMS:fix_skip
Jun 28, 2022
Merged

[conditional mark] To add test_thermal_control_load_invalid_value_json skip for Cisco.#5875
StormLiangMS merged 1 commit intosonic-net:masterfrom
StormLiangMS:fix_skip

Conversation

@StormLiangMS
Copy link
Copy Markdown
Collaborator

Description of PR

Summary:
Fixes # (issue)
When delete xfail, mis delete one case which is necessary for Cisco devices in PR https://github.com/Azure/sonic-mgmt/pull/5777/files

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

When delete xfail, mis delete one case which is necessary for Cisco devices in PR https://github.com/Azure/sonic-mgmt/pull/5777/files, to add it back in this PR.

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@StormLiangMS StormLiangMS requested a review from a team as a code owner June 27, 2022 10:03
@wangxin
Copy link
Copy Markdown
Collaborator

wangxin commented Jun 27, 2022

@StormLiangMS Can you improve the PR title? The current title is not descriptive enough.

@StormLiangMS StormLiangMS changed the title fix skip [conditional mark] To add test_thermal_control_load_invalid_value_json skip for Cisco. Jun 28, 2022
@StormLiangMS
Copy link
Copy Markdown
Collaborator Author

@StormLiangMS Can you improve the PR title? The current title is not descriptive enough.

@wangxin sure.

@StormLiangMS StormLiangMS merged commit ce53d79 into sonic-net:master Jun 28, 2022
wangxin pushed a commit that referenced this pull request Jun 30, 2022
…n skip for Cisco (#5875)

What is the motivation for this PR?
When delete xfail, mis delete one case which is necessary for Cisco devices in PR https://github.com/Azure/sonic-mgmt/pull/5777/files, to add it back in this PR.

How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants