[Mellanox]Get a valid mac adderss for Mellanox switch in test_host_vlan#5869
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Jun 28, 2022
Merged
Conversation
The test need to configure a new mac address other than the switch mac on a vlan interface. The community uses "00:11:22:33:44:55" as the new address. But for our asics, we don't support this kind of mac address. So add a new logic to get a valid mac address for Mellanox duts.
nhe-NV
approved these changes
Jun 27, 2022
liat-grozovik
approved these changes
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
The host vlan test now configures a new mac address(00:11:22:33:44:55) other than the switch mac on a vlan interface.
But for Mellanox asics, there is a restriction that we don't support this kind of mac address, because this address is not under the same prefix(36-38 bits) of the switch mac.
So need to add a new logic to get a valid mac address for the vlan interface on Mellanox duts.
Type of change
Back port request
Approach
What is the motivation for this PR?
Run host vlan test successfully on Mellanox asics.
How did you do it?
Adding a new logic, if the asic is Mellanox, flap the bits in the last octet to generate a new mac address for the test instead of "00:11:22:33:44:55".
How did you verify/test it?
Run test on spc1/spc2/spc3 duts, all passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation