[VXLAN_ECMP] Workaround to have separate setup and teardown for each supported encap type#5858
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Jun 28, 2022
Conversation
…ap type in test_vxlan_ecmp
5 tasks
Contributor
rraghav-cisco
left a comment
rraghav-cisco
left a comment
There was a problem hiding this comment.
Is a command line argument being added as "encap_type"? if so, pls update the documentation at the top of the script to include encap_type.
Author
No, "encap type" is just a fixture, not a command-line argument. The list of supported encap types is defined in the const inside the test as it was initially. |
rraghav-cisco
approved these changes
Jun 26, 2022
liat-grozovik
approved these changes
Jun 28, 2022
liat-grozovik
pushed a commit
that referenced
this pull request
Jul 20, 2022
…or each supported encap type (5993) Backport to 202012 of #5858 Included PR: #5873 Summary: Separate configuration and teardown for each supported encapsulation type: ['v4_in_v4', 'v4_in_v6', 'v6_in_v4', 'v6_in_v6'] - What is the motivation for this PR? Fix the test issue when two types of tunnels (v4 and v6) configured at the same time - How did you do it? By using an additional fixture, which allows to do setup and teardown for each encap type - How did you verify/test it? By running test in the nightly regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Separate configuration and teardown for each supported encapsulation type: ['v4_in_v4', 'v4_in_v6', 'v6_in_v4', 'v6_in_v6']
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix the test issue when two types of tunnels (v4 and v6) configured at the same time
How did you do it?
By using an additional fixture, which allows to do setup and teardown for each encap type
How did you verify/test it?
By running test in the nightly regression