Skip to content

Bypass replace_lane to unblock submodule update #5847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wen587 merged 2 commits into from
Jun 22, 2022
Merged

Bypass replace_lane to unblock submodule update #5847

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4481316
bypass replace_lane to unblock submodule update
wen587 Jun 21, 2022
231b320
change to skip mark
wen587 Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions tests/generic_config_updater/test_eth_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,29 +94,29 @@ def test_remove_lanes(duthost, ensure_dut_readiness):
delete_tmpfile(duthost, tmpfile)


def test_replace_lanes(duthost, ensure_dut_readiness):
cur_lanes = check_interface_status(duthost, "Lanes")
cur_lanes = cur_lanes.split(",")
cur_lanes.sort()
update_lanes = cur_lanes
update_lanes[-1] = str(int(update_lanes[-1]) + 1)
update_lanes = ",".join(update_lanes)
json_patch = [
{
"op": "replace",
"path": "/PORT/Ethernet0/lanes",
"value": "{}".format(update_lanes)
}
]

tmpfile = generate_tmpfile(duthost)
logger.info("tmpfile {}".format(tmpfile))

try:
output = apply_patch(duthost, json_data=json_patch, dest_file=tmpfile)
expect_op_failure(output)
finally:
delete_tmpfile(duthost, tmpfile)
#def test_replace_lanes(duthost, ensure_dut_readiness):
Copy link
Copy Markdown
Contributor

@qiluo-msft qiluo-msft Jun 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_replace_lanes

Could you use @pytest.mark.skip(reason="...") and provide a reason?

Currently I could not understand the motivation from your PR description. #Closed

Copy link
Copy Markdown
Contributor Author

@wen587 wen587 Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

# cur_lanes = check_interface_status(duthost, "Lanes")
# cur_lanes = cur_lanes.split(",")
# cur_lanes.sort()
# update_lanes = cur_lanes
# update_lanes[-1] = str(int(update_lanes[-1]) + 1)
# update_lanes = ",".join(update_lanes)
# json_patch = [
# {
# "op": "replace",
# "path": "/PORT/Ethernet0/lanes",
# "value": "{}".format(update_lanes)
# }
# ]
#
# tmpfile = generate_tmpfile(duthost)
# logger.info("tmpfile {}".format(tmpfile))
#
# try:
# output = apply_patch(duthost, json_data=json_patch, dest_file=tmpfile)
# expect_op_failure(output)
# finally:
# delete_tmpfile(duthost, tmpfile)

def test_replace_mtu(duthost, ensure_dut_readiness):
# Can't directly change mtu of the port channel member
Expand Down