[dualtor] Fix test_radv_ipv6_ra#5842
Merged
lolyu merged 2 commits intosonic-net:masterfrom Jun 21, 2022
Merged
Conversation
…tbed Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
|
This pull request fixes 1 alert when merging cf6cf98 into 1307ca3 - view on LGTM.com fixed alerts:
|
yxieca
approved these changes
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
On dualtor testbed,
test_radv_ipv6_racomplains about not able to find fixturecable_type.The root cause is that
request.getfixturevaluedoesn't support parameterized fixtures.How did you do it?
Direct call
toggle_all_simulator_ports_to_upper_torinstead.How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation