Skip to content

Remove unnecessary fdb flush for test_configurable_drop_counters#5821

Draft
ZhaohuiS wants to merge 1 commit intosonic-net:masterfrom
ZhaohuiS:guard/configurable_drop_counters
Draft

Remove unnecessary fdb flush for test_configurable_drop_counters#5821
ZhaohuiS wants to merge 1 commit intosonic-net:masterfrom
ZhaohuiS:guard/configurable_drop_counters

Conversation

@ZhaohuiS
Copy link
Copy Markdown
Contributor

@ZhaohuiS ZhaohuiS commented Jun 16, 2022

Signed-off-by: Zhaohui Sun zhaohuisun@microsoft.com

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

test_configurable_drop_counters may cause orchagent crash during unshutdown interface/flush fdb/remove static fdb these operations.
Issue reported here: sonic-net/sonic-buildimage#11046

How did you do it?

The issue is fixed, but we can remove unnecessary fdb flush for test_configurable_drop_counters.
And also add sleep 3 sec after shutdown interface.

How did you verify/test it?

run test_configurable_drop_counters

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
@ZhaohuiS ZhaohuiS requested a review from a team as a code owner June 16, 2022 00:51
@ZhaohuiS ZhaohuiS marked this pull request as draft June 16, 2022 03:37
@yejianquan
Copy link
Copy Markdown
Collaborator

@ZhaohuiS
Sorry to comment on the draft PR,
I just see there's another related fix pr of swss sonic-net/sonic-swss#2332 from your issue
Should we keep the unnecessary clear to qualify the swss fix?

@ZhaohuiS
Copy link
Copy Markdown
Contributor Author

@ZhaohuiS Sorry to comment on the draft PR, I just see there's another related fix pr of swss Azure/sonic-swss#2332 from your issue Should we keep the unnecessary clear to qualify the swss fix?

@yejianquan Yes, I plan to hold this PR until we can verify 2332 [sonic-net/sonic-swss#2332] really fixes orchagent crash issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants