Increase timeout for sniffing option 82 packets#5686
Merged
ZhaohuiS merged 1 commit intosonic-net:masterfrom May 20, 2022
Merged
Increase timeout for sniffing option 82 packets#5686ZhaohuiS merged 1 commit intosonic-net:masterfrom
ZhaohuiS merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
wangxin
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhaohui Sun zhaohuisun@microsoft.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
test_dhcp_relay.py fails at "Failed: Verifying option 82" sometimes. It means it doesn't sniff any DHCP Relay packet with option 82.
How did you do it?
After debugging, timeout=3 may be too short for waiting relayed discover packets from DUT.
Add timestamp, I found relayed discover packets may arrive at PTF 3s later after starting sniff.
Increase it to 5s to make sure it can capture expected packets.
How did you verify/test it?
run
test_dhcp_relay.pyAny platform specific information?
Supported testbed topology if it's a new test case?
Documentation