Skip to content

[GCU] update pfcwd interval config test #5662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isabelmsft merged 4 commits into from
Apr 3, 2023
Merged

[GCU] update pfcwd interval config test #5662

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b841465
add fix
isabelmsft May 17, 2022
762a460
remove sleep
isabelmsft May 24, 2022
185c66b
Merge branch 'master' into pfcwd_config_add
isabelmsft Mar 31, 2023
602f835
remove whitespace
isabelmsft Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/generic_config_updater/test_pfcwd_interval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@ def get_detection_restoration_times(duthost):
Args:
duthost: DUT host object
"""


duthost.shell('config pfcwd start --action drop all 400 --restoration-time 400', module_ignore_errors=True)
time.sleep(15)
Copy link
Contributor

@qiluo-msft qiluo-msft May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

15

Why 15 seconds? I see other code sleep 5 seconds. Still is it possible not to use magic number at all? For example, sleep until we find a signal that the config take effect.
@neethajohn

Copy link
Contributor

@neethajohn neethajohn May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need 15s. we can check immediately

pfcwd_config = duthost.shell("show pfcwd config")
pytest_assert(not pfcwd_config['rc'], "Unable to read pfcwd config")

Expand Down