Skip to content

[generic_config_updater]Add empty input fixture to verify configDB before GCU tests #5506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wen587 merged 2 commits into from
Apr 13, 2022
Merged

[generic_config_updater]Add empty input fixture to verify configDB before GCU tests #5506

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f060965
Add GCU empty input test to verify functional usage and valid configDB
wen587 Apr 2, 2022
0a086f7
change empty input check with fixture
wen587 Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions tests/generic_config_updater/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import pytest

from tests.common.utilities import skip_release
from tests.generic_config_updater.gu_utils import apply_patch
from tests.generic_config_updater.gu_utils import generate_tmpfile, delete_tmpfile

@pytest.fixture(autouse=True)
def ignore_expected_loganalyzer_exceptions(duthost, loganalyzer):
Expand Down Expand Up @@ -53,3 +55,28 @@ def cfg_facts(duthosts, rand_one_dut_hostname):
"""
duthost = duthosts[rand_one_dut_hostname]
return duthost.config_facts(host=duthost.hostname, source="persistent")['ansible_facts']


@pytest.fixture(scope="module", autouse=True)
def verify_configdb_with_empty_input(duthost):
"""Fail immediately if empty input test failure

Args:
duthost: Hostname of DUT.
Copy link
Copy Markdown
Collaborator

@wangxin wangxin Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duthost is not a hostname. It's an ansible host object that can be used to interact with the DUT device.

Copy link
Copy Markdown
Contributor

@qiluo-msft qiluo-msft Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest @wen587 to fix the comment in another PR.

Copy link
Copy Markdown
Contributor Author

@wen587 wen587 Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Update in next PR: https://github.com/Azure/sonic-mgmt/pull/5509/files#diff-11b9a905e656f51367a09b1436bc8d7e57c59fecbd8e36e54e332c41a88a60e6R42


Returns:
None.
"""
json_patch = []
tmpfile = generate_tmpfile(duthost)

try:
output = apply_patch(duthost, json_data=json_patch, dest_file=tmpfile)
if output['rc'] or "Patch applied successfully" not in output['stdout']:
pytest.fail(
"SETUP FAILURE: ConfigDB fail to validate Yang. rc:{} msg:{}"
.format(output['rc'], output['stdout'])
)

finally:
delete_tmpfile(duthost, tmpfile)