Fix loganalyzer no common config issue and re-balance PR testing#5435
Merged
wangxin merged 6 commits intosonic-net:masterfrom Apr 11, 2022
Merged
Fix loganalyzer no common config issue and re-balance PR testing#5435wangxin merged 6 commits intosonic-net:masterfrom
wangxin merged 6 commits intosonic-net:masterfrom
Conversation
|
This pull request fixes 4 alerts when merging b110d48c9decc60f364e2ef1693d2f108963de32 into 753e956 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 4 alerts when merging 3775b00c36e682abfd709d3013c11533b968bf1e into 753e956 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 4 alerts when merging 9ae6d326d261b8f97b4841698dcb20ad00565ac4 into a6d0104 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 4 alerts when merging aa6f3ab3d8311857fb0fd0e221924b3a1c3ea2d4 into 10e6928 - view on LGTM.com fixed alerts:
|
Loganalyzer was broken in PR sonic-net#3235. The issue is that common config was loaded in subprocess for adding marks to syslog. After the subprocess exited, the common config is lost. PR sonic-net#5193 tried to fix this issue. However, because of many new error logs sneaked in when log analyzer was not working, PR testing started to fail by these error logs after PR sonic-net#5193 was merged. PR sonic-net#5191 and sonic-net#5411 tried to workaround the PR testing failure to unblock PR testing. PR sonic-net#5191 is to address the GCU related error logs and was merged. PR sonic-net#5411 tried to add other error logs to the common ignore list. But the effort took too long because the ignore list seemed endless. To unblock PR testing as soon as possible, the original fix sonic-net#5193 was reverted in sonic-net#5433. This PR tries to complete the work left over from sonic-net#5411 and sonic-net#5433. Changes: 1. Fix the log analyzer common config not loaded issue. 2. Temporarily add error logs to the common ignore list. 3. Improve the logging of log analyzer and parallel_run 4. PR testing t0_part2 takes much more time than t0_part1 after the GCU test scripts are added. This change re-balanced t0 part1&part2 testing by moving some of the tests from part2 to part1. 5. Sorted the PR testing scripts in alphabetic order. Signed-off-by: Xin Wang <[email protected]>
wangxin
force-pushed
the
fix-log-analyzer
branch
from
aa6f3ab to
25d7808
Compare
|
This pull request fixes 4 alerts when merging 25d7808 into 1c6a0bc - view on LGTM.com fixed alerts:
|
|
This pull request fixes 4 alerts when merging 7bbcf0d into 6e2bb2e - view on LGTM.com fixed alerts:
|
wangxin
added a commit
that referenced
this pull request
Apr 11, 2022
What is the motivation for this PR? Loganalyzer was broken in PR #3235. The issue is that common config was loaded in subprocess for adding marks to syslog. After the subprocess exited, the common config is lost. PR #5193 tried to fix this issue. However, because of many new error logs sneaked in when log analyzer was not working, PR testing started to fail by these error logs after PR #5193 was merged. PR #5391 and #5411 tried to work around the PR testing failure to unblock PR testing. PR #5391 is to address the GCU related error logs and was merged. PR #5411 tried to add other error logs to the common ignore list. But the effort took too long because the ignore list seemed endless. To unblock PR testing as soon as possible, the original fix #5193 was reverted in #5433. This PR tries to complete the work left over from #5411 and #5433. How did you do it? Changes: * Fix the log analyzer common config not loaded issue. * Temporarily add error logs to the common ignore list. * Improve the logging of log analyzer and parallel_run * PR testing t0_part2 takes much more time than t0_part1 after the GCU test scripts are added. This change re-balanced t0 part1&part2 testing by moving some of the tests from part2 to part1. * Sorted the PR testing scripts in alphabetic order. How did you verify/test it? Tested run a few test scripts with log analyzer enabled on KVM testbed. Signed-off-by: Xin Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Loganalyzer was broken in PR #3235. The issue is that common config was loaded
in subprocess for adding marks to syslog. After the subprocess exited, the
common config is lost.
PR #5193 tried to fix this issue. However, because of many new error logs sneaked
in when log analyzer was not working, PR testing started to fail by these error
logs after PR #5193 was merged.
PR #5391 and #5411 tried to work around the PR testing failure to unblock PR
testing. PR #5391 is to address the GCU related error logs and was merged.
PR #5411 tried to add other error logs to the common ignore list. But the effort
took too long because the ignore list seemed endless.
To unblock PR testing as soon as possible, the original fix #5193 was reverted
in #5433.
This PR tries to complete the work left over from #5411 and #5433.
How did you do it?
Changes:
scripts are added. This change re-balanced t0 part1&part2 testing by moving
some of the tests from part2 to part1.
How did you verify/test it?
Tested run a few test scripts with log analyzer enabled on KVM testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation