Skip to content

[snmp_facts] increase get command timeout to fix cpu test failure #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yxieca merged 3 commits into from
Mar 20, 2018
Merged

[snmp_facts] increase get command timeout to fix cpu test failure #525

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3999e9
[snmp_fact] Add debug information to each failure
yxieca Mar 19, 2018
f82db34
[snmp_facts] separate system description query
yxieca Mar 19, 2018
0fb152e
Update snmp_facts.py
yxieca Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions ansible/library/snmp_facts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,10 +290,26 @@ def main():

results = Tree()

# Getting system description could take more than 1 second on some Dell platform
# (e.g. S6000), increse timeout to tolerate the delay.
Copy link
Contributor

@qiluo-msft qiluo-msft Mar 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with high CPU utilization

errorIndication, errorStatus, errorIndex, varBinds = cmdGen.getCmd(
snmp_auth,
cmdgen.UdpTransportTarget((m_args['host'], 161)),
cmdgen.UdpTransportTarget((m_args['host'], 161), timeout=5.0),
cmdgen.MibVariable(p.sysDescr,),
)

if errorIndication:
module.fail_json(msg=str(errorIndication) + ' querying system description.')

for oid, val in varBinds:
current_oid = oid.prettyPrint()
current_val = val.prettyPrint()
if current_oid == v.sysDescr:
results['ansible_sysdescr'] = decode_hex(current_val)

errorIndication, errorStatus, errorIndex, varBinds = cmdGen.getCmd(
snmp_auth,
cmdgen.UdpTransportTarget((m_args['host'], 161)),
cmdgen.MibVariable(p.sysObjectId,),
cmdgen.MibVariable(p.sysUpTime,),
cmdgen.MibVariable(p.sysContact,),
Expand All @@ -302,14 +318,12 @@ def main():
)

if errorIndication:
module.fail_json(msg=str(errorIndication))
module.fail_json(msg=str(errorIndication) + ' querying system infomation.')

for oid, val in varBinds:
current_oid = oid.prettyPrint()
current_val = val.prettyPrint()
if current_oid == v.sysDescr:
results['ansible_sysdescr'] = decode_hex(current_val)
elif current_oid == v.sysObjectId:
if current_oid == v.sysObjectId:
results['ansible_sysobjectid'] = current_val
elif current_oid == v.sysUpTime:
results['ansible_sysuptime'] = current_val
Expand Down Expand Up @@ -337,7 +351,7 @@ def main():
)

if errorIndication:
module.fail_json(msg=str(errorIndication))
module.fail_json(msg=str(errorIndication) + ' querying interface details')

interface_indexes = []

Expand Down Expand Up @@ -401,7 +415,7 @@ def main():
)

if errorIndication:
module.fail_json(msg=str(errorIndication))
module.fail_json(msg=str(errorIndication) + ' querying interface counters')

for varBinds in varTable:
for oid, val in varBinds:
Expand Down Expand Up @@ -458,7 +472,7 @@ def main():
)

if errorIndication:
module.fail_json(msg=str(errorIndication))
module.fail_json(msg=str(errorIndication) + ' querying CPU busy indeces')

for oid, val in varBinds:
current_oid = oid.prettyPrint()
Expand All @@ -476,7 +490,7 @@ def main():
)

if errorIndication:
module.fail_json(msg=str(errorIndication))
module.fail_json(msg=str(errorIndication) + ' querying PFC counters')

for varBinds in varTable:
for oid, val in varBinds:
Expand Down Expand Up @@ -504,7 +518,7 @@ def main():
)

if errorIndication:
module.fail_json(msg=str(errorIndication))
module.fail_json(msg=str(errorIndication) + ' querying QoS stats')

for varBinds in varTable:
for oid, val in varBinds:
Expand All @@ -524,7 +538,7 @@ def main():
)

if errorIndication:
module.fail_json(msg=str(errorIndication))
module.fail_json(msg=str(errorIndication) + ' querying FRU')

for varBinds in varTable:
for oid, val in varBinds:
Expand Down