[fwutil] Fix Various Bugs Identified in Regression#5130
Merged
sujinmkang merged 13 commits intosonic-net:masterfrom Mar 7, 2022
Merged
[fwutil] Fix Various Bugs Identified in Regression#5130sujinmkang merged 13 commits intosonic-net:masterfrom
sujinmkang merged 13 commits intosonic-net:masterfrom
Conversation
…or switch to go down.
alexrallen
changed the title
liat-grozovik
approved these changes
Feb 13, 2022
Collaborator
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@sujinmkang kindly reminder to review and signoff |
sujinmkang
approved these changes
Mar 2, 2022
wangxin
added a commit
that referenced
this pull request
Mar 15, 2022
…5312) Reverts #5130 Need to revert this PR for the same reason as PR #5282. The dependent pytest-allure package which is only available to user “AzDevOps” in sonic-mgmt docker because it is installed to local path of that user: ``` AzDevOps@2fb15ed04ed5:~$ python Python 2.7.17 (default, Feb 27 2021, 15:10:58) [GCC 7.5.0] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import allure >>> allure.__file__ '/var/AzDevOps/.local/lib/python2.7/site-packages/allure.pyc' AzDevOps@2fb15ed04ed5:~$ sudo su root@2fb15ed04ed5:/var/AzDevOps# pip list | grep allure DEPRECATION: The default format will switch to columns in the future. You can use --format=(legacy|columns) (or define a format=(legacy|columns) in your pip.conf under the [list] section) to disable this warning. root@2fb15ed04ed5:/var/AzDevOps# python Python 2.7.17 (default, Feb 27 2021, 15:10:58) [GCC 7.5.0] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import allure Traceback (most recent call last): File "<stdin>", line 1, in <module> ImportError: No module named allure >>> exit() ``` I’ll revert this PR for now to unblock testing using root account. The sonic-mgmt docker file https://github.com/Azure/sonic-buildimage/blob/master/dockers/docker-sonic-mgmt/Dockerfile.j2 needs to be updated to ensure that package pytest-allure is installed to global directory.
alexrallen
added a commit
to alexrallen/sonic-mgmt
that referenced
this pull request
Mar 29, 2022
…onic-net#5130)" (sonic-net#5312)" This reverts commit 7018318.
liat-grozovik
pushed a commit
that referenced
this pull request
Apr 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Set of general fixes made during Mellanox implementation of the fwutil tests into nightly regression
fwutil update alltestssonic_installerand rebootingType of change
Back port request