Skip to content

Revert GCU cacl test due to random failure and add sleep in cacl for local test #5046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wen587 merged 2 commits into from
Jan 29, 2022
Merged

Revert GCU cacl test due to random failure and add sleep in cacl for local test #5046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47461f0
fix failure
wen587 Jan 28, 2022
1b10558
revert cacl test
wen587 Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/generic_config_updater/test_cacl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import logging
import pytest
import time

from tests.common.helpers.assertions import pytest_assert
from tests.generic_config_updater.gu_utils import apply_patch, expect_op_success, expect_res_success, expect_op_failure
Expand Down Expand Up @@ -94,6 +95,7 @@ def expect_acl_table_match(duthost, table_name, expected_content_list):
def expect_res_success_acl_rule(duthost, expected_content_list, unexpected_content_list):
"""Check if acl rule added as expected
"""
time.sleep(1) # Sleep 1 sec to ensure caclmgrd does update in case of its UPDATE_DELAY_SECS 0.5s
Copy link
Copy Markdown
Contributor

@qiluo-msft qiluo-msft Jan 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a short term solution. And we need to understand if this is a feature bug. Please remove it after feature fix.

Copy link
Copy Markdown
Contributor Author

@wen587 wen587 Jan 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Thanks

cmds = "iptables -S"
output = duthost.shell(cmds)
pytest_assert(not output['rc'],
Expand Down
1 change: 0 additions & 1 deletion tests/kvmtest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ test_t0() {
container_checker/test_container_checker.py \
process_monitoring/test_critical_process_monitoring.py \
system_health/test_system_status.py \
generic_config_updater/test_cacl.py \
generic_config_updater/test_lo_interface.py \
generic_config_updater/test_vlan_interface.py \
generic_config_updater/test_portchannel_interface.py \
Expand Down