Acl toggle interfaces#504
Closed
simone-dell wants to merge 7 commits intosonic-net:masterfrom
simone-dell:ACL-Toggle-Interfaces
Closed
Acl toggle interfaces#504simone-dell wants to merge 7 commits intosonic-net:masterfrom simone-dell:ACL-Toggle-Interfaces
simone-dell wants to merge 7 commits intosonic-net:masterfrom
simone-dell:ACL-Toggle-Interfaces
Conversation
Added ICMP test - create ptf icmp packet and make sure it is rejected based on drop icmp rule
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
…warning (sonic-net#504) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: The ignore pattern for leapsecond file expired warning is incorrect. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? The following syslog should be ignored. 2025 Jul 1 09:30:14.223456 bjw2-can-8102-1 ERR ntpd[224326]: CLOCK: leapsecond file ('/usr/share/zoneinfo/leap-seconds.list'): expired less than 4 days ago #### How did you do it? Change the ignore pattern #### How did you verify/test it? Verify with physical testbed #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-net#2759) Submodule src/sonic-sairedis 483c89e..97dd2a8: > Fix compilation issues in stretch docker with gcc-6.3 (sonic-net#426) > Make object list deterministic when iterating (sonic-net#438) > Ignore ACL_COUNTER bytes and packets during comparison logic (sonic-net#443) Submodule src/sonic-swss d22b2de..ae74a27: > Survive pfc watchdog storm action across warm-reboot (sonic-net#794) Submodule src/sonic-swss-common 36fd5e9..24c0ff7: > Update PFC_WD table name in CONFIG_DB (sonic-net#266) Submodule src/sonic-utilities bae21e7..6aee909: > [neighbor advertiser] convert int to string before concatenating (sonic-net#505) > [config]: Change the order of interface commands (sonic-net#504) > Change PFC watchdog CONFIG_DB table name from PFC_WD_TABLE to PFC_WD (sonic-net#475) Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…tomatically (#23554) #### Why I did it src/sonic-linux-kernel ``` * 84db3a0 - (HEAD -> 202411, origin/202411) Fix slave container used for 202411 branch (sonic-net#504) (12 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixes # (issue)
Added a change to acltb.yml that toggles interfaces up/down to make sure acl rules are intact after port shutdown / no shutdown
Type of change
Approach
How did you do it? Added one step in the acl test run that toggles all interfaces up and down, reruns the PTF test, and makes sure that the tests still run after the interfaces are back up
How did you verify/test it? Ran it in my local repo
Any platform specific information? No
Supported testbed topology if it's a new test case? t1, t1-lag, t1-64-lag
Documentation