Conversation
|
Incremental change of MTU and admin_status is not supported. Do we need to remove that in sonic-vlan.yang? |
But the PR title says vlan interface In reply to: 1000107821 |
| fe80::5054:ff:feda:c6af%Vlan1000/64 N/A N/A | ||
| """ | ||
| address_family = "ip" if is_ipv4 else "ipv6" | ||
| output = duthost.shell("show {} interfaces | grep {} || true".format(address_family, intf_name)) |
There was a problem hiding this comment.
If grep no output, it will return a failure with error code 1. If there is a scenario we grep a non-existed variable, we can check if output is empty instead of fail.
There was a problem hiding this comment.
Catching return code 1 is better to ignore any return code. The whole command could fail with other reasons such as some container stopped (so failed before first pipe), and they will lead to different return code.
There was a problem hiding this comment.
Please see here #4835 (comment)
Seems we can only capture the error of the last pipe command.
The whole command could fail with other reasons such as some container stopped (so failed before first pipe), and they will lead to different return code.
Even though the command fail before first pipe, the return code is only related to the last pipe.
…ric config updater (sonic-net#4834) Summary: Testcase of VLAN interface for generic updater apply-patch. Move some functions to gu_utils. What is the motivation for this PR? End to End test support for Generic Updater apply-patch This PR is to verify the usage of 'config apply-patch' works on VLAN interface How did you do it? Make some config apply change based on predefined t0 topo. And check if the VLAN interface is changed as expected. How did you verify/test it? Run test of sonic-mgmt/tests/generic_config_updater/test_vlan_interface.py on KVM
2 participants
Description of PR
Summary: Testcase of vlan interface for generic updater apply-patch
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
End to End test support for Generic Updater apply-patch
This PR is to verify the usage of 'config apply-patch' works on vlan interface
How did you do it?
Make some config apply change based on predefined t0 topo. And check if the vlaninterface is changed as expected.
How did you verify/test it?
Run test of sonic-mgmt/tests/generic_config_updater/test_vlan_interface.py on KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation