Merged
Conversation
qiluo-msft
reviewed
Dec 7, 2021
qiluo-msft
reviewed
Dec 7, 2021
qiluo-msft
reviewed
Dec 7, 2021
qiluo-msft
reviewed
Dec 7, 2021
qiluo-msft
reviewed
Dec 11, 2021
qiluo-msft
reviewed
Dec 15, 2021
qiluo-msft
previously approved these changes
Dec 15, 2021
qiluo-msft
reviewed
Dec 20, 2021
qiluo-msft
reviewed
Dec 20, 2021
Contributor
As other shell command, seem In reply to: 997668910 Refers to: tests/generic_config_updater/gu_utils.py:126 in 19dd653. [](commit_id = 19dd653, deletion_comment = False) |
Contributor
ghooo
reviewed
Dec 20, 2021
ghooo
reviewed
Dec 20, 2021
ghooo
reviewed
Dec 20, 2021
qiluo-msft
previously approved these changes
Dec 20, 2021
Contributor
qiluo-msft
left a comment
qiluo-msft
left a comment
There was a problem hiding this comment.
LGTM. Please also check with other reviewers.
isabelmsft
reviewed
Dec 21, 2021
ghooo
approved these changes
Dec 21, 2021
qiluo-msft
approved these changes
Dec 22, 2021
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
…generic config updater (sonic-net#4814) Summary: Testcase of loopback interface for generic updater apply-patch. Add checkpoint and rollback in gu_utils. What is the motivation for this PR? End to End test support for Generic Updater apply-patch This PR is to verify the usage of 'config apply-patch' works on loopback interface How did you do it? Make changes to loopback interface thru 'config apply-patch'. Then check if the loopback interface is changed as expected. How did you verify/test it? Run test of sonic-mgmt/tests/generic_config_updater/test_lo_interface.py on KVM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Testcase of loopback interface for generic updater apply-patch
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
End to End test support for Generic Updater apply-patch
This PR is to verify the usage of 'config apply-patch' works on loopback interface
How did you do it?
First we setup clean loopback interface env. Then make some config apply change. And check if the loopback interface is changed as expected.
How did you verify/test it?
Run test of sonic-mgmt/tests/generic_config_updater/test_lo_interface.py on KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation