Fix test_bgp_update_timer failure caused by scapy upgrade in sonic-mg docker image#4774
Merged
wangxin merged 2 commits intosonic-net:masterfrom Nov 29, 2021
Merged
Conversation
…mt docker image The scapy package in sonic-mgmt docker image was upgraded in PR sonic-net/sonic-buildimage#8554. The new version of scapy uses a different way to represent and dissect BGP messages. This caused the failure of test_bgp_update_time.py. This PR is to address the compatibility issue of scapy. The test_bgp_update_timer.py script was updated to be be compatible with both old and new scapy versions. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
lolyu
approved these changes
Nov 29, 2021
bingwang-ms
approved these changes
Nov 29, 2021
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
… docker image (sonic-net#4774) What is the motivation for this PR? The scapy package in sonic-mgmt docker image was upgraded in PR sonic-net/sonic-buildimage#8554. The new version of scapy uses a different way to represent and dissect BGP messages. This caused the failure of test_bgp_update_time.py. How did you do it? This PR is to address the compatibility issue of scapy. The test_bgp_update_timer.py script was updated to be be compatible with both old and new scapy versions. How did you verify/test it? Run bgp/test_bgp_update_timer.py using both old and new sonic-mgmt docker image. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The scapy package in sonic-mgmt docker image was upgraded in PR sonic-net/sonic-buildimage#8554.
The new version of scapy uses a different way to represent and dissect BGP messages. This caused the failure of
test_bgp_update_time.py.
How did you do it?
This PR is to address the compatibility issue of scapy. The test_bgp_update_timer.py script was updated to be
be compatible with both old and new scapy versions.
How did you verify/test it?
Run
bgp/test_bgp_update_timer.pyusing both old and new sonic-mgmt docker image.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation