Fan speed should not be 100% when PSU is powered off#4692
Merged
wangxin merged 2 commits intosonic-net:masterfrom Dec 1, 2021
Merged
Fan speed should not be 100% when PSU is powered off#4692wangxin merged 2 commits intosonic-net:masterfrom
wangxin merged 2 commits intosonic-net:masterfrom
Conversation
Change-Id: Ibe7f9d844e9c680a2f7f0ff06a90b0f467a45388
Change-Id: I3f59a04e8b45b22e3b71c47860efac3e208d00e0
Contributor
|
@sujinmkang could you please take a look when you have time? |
liat-grozovik
approved these changes
Nov 22, 2021
Collaborator
|
@sujinmkang could you please help to review (as you were the one to review the dependent PR :-) ) |
Contributor
Author
|
@sujinmkang Hi, could you please review and sign off? |
wangxin
approved these changes
Dec 1, 2021
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
What is the motivation for this PR? PSU policy is changed in production code, power off PSU no longer triggers thermal control algorithm, and test case is updated in this PR accordingly How did you do it? Add a test case, fan speed should be 100% when PSU is absence Remove existing test case that power off PSU and check fan speed How did you verify/test it? Manually run the test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on sonic-net/sonic-buildimage#9258
Change-Id: Ibe7f9d844e9c680a2f7f0ff06a90b0f467a45388
Description of PR
Summary:
PSU policy is changed in production code, power off PSU no longer triggers thermal control algorithm, and test case is updated in this PR accordingly
Type of change
Back port request
Approach
What is the motivation for this PR?
PSU policy is changed in production code, power off PSU no longer triggers thermal control algorithm, and test case is updated in this PR accordingly
How did you do it?
How did you verify/test it?
Manually run the test cases
Any platform specific information?
Mellanox
Supported testbed topology if it's a new test case?
N/A
Documentation