[Vrf] Disable swss warm_boot flag after test_vrf_swss_warm_reboot#4636
Merged
wangxin merged 1 commit intosonic-net:masterfrom Nov 17, 2021
Merged
[Vrf] Disable swss warm_boot flag after test_vrf_swss_warm_reboot#4636wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Andrii-Yosafat Lozovyi <andrii-yosafatx.lozovyi@intel.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Nov 17, 2021
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
…nic-net#4636) What is the motivation for this PR? After PR - sonic-net/sonic-utilities#1460 additional check was added to ensure, that before issuing an warm_reboot there are no warm_reboot flags set. test_vrf_swss_warm_reboot enables warm_boot flag for swss by using cmd - config warm_restart enable swss, but after restart of swss, next test case fails to make warm_reboot of system due to this flag is still set. Error message: Warm restart flag for swss is set. Please check if a warm restart for swss is in progress. How did you do it? Disable swss warm_boot flag after test_vrf_swss_warm_reboot. How did you verify/test it? Run vrf/test_vrf.py::TestVrfWarmReboot, test_vrf_system_warm_reboot gets executed. Signed-off-by: Andrii-Yosafat Lozovyi <andrii-yosafatx.lozovyi@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrii-Yosafat Lozovyi andrii-yosafatx.lozovyi@intel.com
Description of PR
Summary: After PR - 1460 additional check was added to ensure, that before issuing an warm_reboot there are no warm_reboot flags set.
test_vrf_swss_warm_rebootenables warm_boot flag for swss by using cmd -config warm_restart enable swss, but after restart of swss, next test case fails to make warm_reboot of system due to this flag is still set.Error message:
Warm restart flag for swss is set. Please check if a warm restart for swss is in progress.Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Disable swss warm_boot flag after test_vrf_swss_warm_reboot.
How did you do it?
How did you verify/test it?
Run
vrf/test_vrf.py::TestVrfWarmReboot,test_vrf_system_warm_rebootgets executed.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation