[upgrade] don't fail playbook if the image is the same as installed#459
Closed
maggiemsft wants to merge 1 commit intosonic-net:masterfrom
Closed
[upgrade] don't fail playbook if the image is the same as installed#459maggiemsft wants to merge 1 commit intosonic-net:masterfrom
maggiemsft wants to merge 1 commit intosonic-net:masterfrom
Conversation
lguohan
reviewed
Feb 11, 2018
| ignore_errors: yes | ||
|
|
||
| - fail: msg="SONiC upgrade failed" | ||
| when: (output.rc != 0) and (not "'Running SONiC has the same version' in {{ output.stdout }}") |
Contributor
There was a problem hiding this comment.
in this case, I think sonic_installer should return success as well. can you create an issue for sonic_installer for this?
Contributor
Author
|
fixed it in image, not test |
sdszhang
added a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Jun 30, 2025
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Change in this update:
b75aab7 [swss-common] Add LINKMGR CFG and MUX LINKMGR state table names (sonic-net#421)
4a77d1c [ci]: add vstest (sonic-net#459)
07258a6 [ci]: use build template (sonic-net#457)
ddcae3e runRedisScript api to process integer returned by script run in the redis (sonic-net#447)
33d89c7 [systemlag] Schema defs for system lag (sonic-net#448)
af01f37 spell check fixes (sonic-net#456)
7afd43d Update to make getNamespaces() API at par with the get_ns_list() swssdk-py API. (sonic-net#455)
signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (#23749) #### Why I did it src/sonic-gnmi ``` * b621858 - (HEAD -> 202505, origin/202505) Upgrade mops setpackage (sonic-net#459) (sonic-net#483) (17 hours ago) [Dawei Huang] ``` #### How I did it #### How to verify it #### Description for the changelog
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…tomatically (sonic-net#22290) #### Why I did it src/sonic-linux-kernel ``` * a89afbc - (HEAD -> 202411, origin/202411) [202411] Update to Linux 6.1.123 (sonic-net#459) (4 days ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
don't fail playbook if the image is the same as installed
Type of change
Approach
How did you do it?
upgrade.yml playbook: doing sonic upgrade to the same image will fail the playbook
may it fail only when install fail but not due to try to install the same image
How did you verify/test it?
verified in my local testbed
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation