Verify buffer priority groups for all platforms#4482
Merged
liat-grozovik merged 5 commits intosonic-net:masterfrom Oct 26, 2021
stephenxs:reclaim-buffer-201911-all-platform
Merged
Verify buffer priority groups for all platforms#4482liat-grozovik merged 5 commits intosonic-net:masterfrom stephenxs:reclaim-buffer-201911-all-platform
liat-grozovik merged 5 commits intosonic-net:masterfrom
stephenxs:reclaim-buffer-201911-all-platform
Conversation
…anager in 201911 (#3889) ### Description of PR Summary: Add test case for traditional buffer manager for fundamental functionalities and reclaiming unused buffer. ### Approach #### What is the motivation for this PR? Add test case for traditional buffer manager for fundamental functionalities and reclaiming unused buffer. #### How did you do it? 1. For all ports in the config_db, - Check whether there is no lossless buffer PG configured on an admin-down port - Check whether the lossless PG aligns with the port's speed and cable length - If the name-to-OID maps exist for port and PG, check whether the information in ASIC_DB aligns with that in CONFIG_DB - If a lossless profile hasn't been checked, check whether the lossless profile in CONFIG_DB aligns with - pg_profile_lookup.ini according to speed and cable length - information in ASIC_DB 2. Shutdown a port and check whether the lossless buffer PG has been removed 3. Startup the port and check whether the lossless PG has been readded. #### How did you verify/test it? Run regression test.
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
stephenxs
changed the title
Contributor
Author
|
/azpw run |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stephen Sun <[email protected]>
neethajohn
approved these changes
Oct 21, 2021
tests/qos/test_buffer_traditional.py
Outdated
| port_to_shutdown = admin_up_ports.pop() | ||
| expected_profile = duthost.shell('redis-cli -n 4 hget "BUFFER_PG|{}|3-4" profile'.format(port_to_shutdown))['stdout'] | ||
| try: | ||
| # Shutdown the port and check whether the lossless PG has been removed |
Contributor
There was a problem hiding this comment.
update comment.. lossless PG has been removed on Mellanox
Contributor
Author
There was a problem hiding this comment.
Fixed. Adjusted comment in other places as well.
Contributor
|
Depends on sonic-net/sonic-swss#1837. Will merge after that PR is in |
Signed-off-by: Stephen Sun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Verify buffer priority groups for non-Mellanox platforms as well.
Signed-off-by: Stephen Sun [email protected]
How did you do it?
How did you verify/test it?
It was verified on Mellanox platform. An old image without reclaiming buffer is adapted to simulate non-Mellanox platform.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation