Update homebrew ansible modules to use log rotation#4446
Merged
yutongzhang-microsoft merged 5 commits intosonic-net:masterfrom Oct 13, 2021
Merged
Update homebrew ansible modules to use log rotation#4446yutongzhang-microsoft merged 5 commits intosonic-net:masterfrom
yutongzhang-microsoft merged 5 commits intosonic-net:masterfrom
Conversation
|
This pull request introduces 8 alerts when merging 2b82690 into c517cb9 - view on LGTM.com new alerts:
|
Collaborator
|
Can you address the LGTM alerts? |
|
This pull request introduces 5 alerts when merging 4dae88c into 6c0a8c2 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging f447ec3 into 6c0a8c2 - view on LGTM.com new alerts:
|
wangxin
approved these changes
Oct 9, 2021
|
This pull request introduces 3 alerts when merging 5fe3d73 into 33d44e6 - view on LGTM.com new alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Some homebrew ansible modules may generate log files to
/tmpfolder on the host that it was executed. These modules manage the log files by their own and do not support log rotation. A new log rotation capable module utility was added in #4302Update below ansible modules to use the new tool for logging:
ansible/roles/vm_set/library/sonic_kickstart.py
ansible/roles/vm_set/library/ceos_network.py
ansible/roles/vm_set/library/kickstart.py
ansible/roles/vm_set/library/vm_topology.py
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Use the new log rotation capable module utility which was added in #4302 to support log rotation.
How did you do it?
I import the new log rotation capable module utility at the front of each file and use it to support log rotation. Meanwhile, I delete the previous functions which were related to the log.
How did you verify/test it?
I use ./testbed-cli.sh add-topo, deploy-mg and remove-topo to test it.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation