[multi-asic][vs]: Use the right KVM platform string for multi-asic vs#4335
Merged
SuvarnaMeenakshi merged 1 commit intosonic-net:masterfrom Sep 24, 2021
Merged
Conversation
vs. New multi-asic KVM platform strings were added. This string is required to get the right port-config file when bringing up virtual switch. Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
wangxin
approved these changes
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Error is seen when doing add-topo to bring up a multi-asic testbed.
Reason:
sonic-net/sonic-buildimage#8269 added new multi-asic KVM platforms, for 4-asic and 6-asic VS.
When add-topo is done, port_alias.py runs on localhost to get the right front-panel interfaces so that VS can be brought up with the right number of front-panel interfaces. With the above PR, new platform string was added due to which port-config.ini file was under a new KVM platform directory, due to which the port config file was not being retrieved correctly.
How did you do it?
Based on number of asics, use the right KVM platform string so that the right port-config file can be retrieved when bringing up VS testbed.
How did you verify/test it?
Was able to bring up VS testbed without the above error.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation