Skip to content

systemd: Move flushall command temporarily to syncd.service file #43

Merged
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:handler
Nov 16, 2016
Merged

systemd: Move flushall command temporarily to syncd.service file #43
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:handler

Conversation

@stcheng
Copy link
Contributor

@stcheng stcheng commented Nov 16, 2016

No description provided.

@pavel-shirshov
Copy link
Contributor

pavel-shirshov commented Nov 16, 2016

Should we add this to the playbook
- meta: flush_handlers

To make the handlers more predictable?

@stcheng
Copy link
Contributor Author

stcheng commented Nov 16, 2016

doesn't seem to be the right way of doing this
will need to find another workaround

This change works as for now syncd doesn't fully support restart from
the point when the database is not flushed due to SAI implementation is
not fully implemented. Later when the syncd supports, we could remove
this line.
@stcheng
Copy link
Contributor Author

stcheng commented Nov 16, 2016

updated

Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the pull request title before merge

@stcheng stcheng changed the title Add restart orchagent docker handler systemd: Move flushall command temporarily to syncd.service file Nov 16, 2016
@stcheng stcheng merged commit 8c613e2 into sonic-net:master Nov 16, 2016
@stcheng stcheng deleted the handler branch November 16, 2016 22:57
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
[202012][sonic-linkmgrd]Submodule update

8507629 Jing Zhang      Mon Apr 4 10:25:22 2022 -0700   Lower unsolicited MUX state change notification log level to WARNING sonic-net#57
17d217d Longxiang Lyu   Mon Mar 21 12:15:19 2022 +0800  Enhance clang format (sonic-net#46)
c72fa2a Jing Zhang      Fri Apr 1 12:23:29 2022 -0700   Disable the feature that decreases link probe interval for measuring switch overhead sonic-net#49 (sonic-net#54)
256b01b Jing Zhang      Thu Mar 31 16:20:00 2022 -0700  Update link prober metrics posting logics sonic-net#50 sonic-net#53
dfd48d0 Jing Zhang      Wed Mar 23 16:27:45 2022 -0700  Decrease link probing interval after switchover to better determine the overhead of a toggle sonic-net#43 (sonic-net#48)

sign-off: Jing Zhang [email protected]
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…-daemons (sonic-net#3420)

* advance pointer for sonic-platform-daemon to 9e2eb29e6e55a116b424faa63f510c7cdeeef7eb
[xcvrd] fix issue: xcvrd fails due to syntax error after sequential reboot (sonic-net#43)

* advance pointer for sonic-platform-common to ac7fde6e9ce532d450b3c43f354fc2f128053b4f
[sonic_sfp] fix syntax error in sfputilbase._read_eeprom_specific_bytes (sonic-net#58)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…t#4302)

Brief:
The community code for has been updated, which mismatched with the existing sonic-mgmt-framework. Hence it broke the build.

Submodule-PR: sonic-net#43

Details:
The SONiC mgmt Framework, pulls down the community modules in two steps.

Pull the existing; This does a transparent compile too.
Then checkout the specific commit-id for each and do the final compile.
The community code change broke in the compilation phase of step-1.
Fix: For the two affected modules, do download only.

Proper fix:
As part of the next phase of changes, the mgmt-framework is moving go-submodule mode, which will ensure the download happens for the assigned commit-ids only.
e.g. Refer go.mod in sonic-telemetry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants