Skip to content

add missing snmp testcases to top level snmp.yml; fixed wrong test fi… #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lguohan merged 1 commit into from
Jan 19, 2018
Merged

add missing snmp testcases to top level snmp.yml; fixed wrong test fi… #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ansible/roles/test/tasks/arpall.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
become: yes

# Send Unicast ARP request from correct interface, expecting reply
- name: Send correct arp packets (10.10.1.3 to 10.10.1.2 with src_mac=00:06:07:08:09:00)
- name: Send correct unicast arp packets (10.10.1.3 to 10.10.1.2 with src_mac=00:06:07:08:09:00)
command: ptf --test-dir acstests arptest.VerifyUnicastARPReply --platform remote -t "acs_mac='{{ ansible_Ethernet4['macaddress'] }}'"
args:
chdir: /root
Expand Down
6 changes: 6 additions & 0 deletions ansible/roles/test/tasks/snmp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,10 @@
- name: Validating SNMP was successful and Hostname is what is expected
assert: { that: "ansible_sysname == '{{ inventory_hostname }}'" }

- block:
- name: inlcude snmp cpu test
include: roles/test/tasks/snmp/cpu.yml

- name: include snmp interfaces test
include: roles/test/tasks/snmp/interfaces.yml
when: testcase_name is defined
4 changes: 2 additions & 2 deletions ansible/roles/test/vars/testcases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,14 @@ testcases:
testbed_type:

neighbour:
filename: neighbour.yml
filename: neighbour-mac.yml
topologies: [ptf32, ptf64]
required_vars:
ptf_host:

neighbour_mac_noptf:
filename: neighbour-mac-noptf.yml
topologies: [ptf32, ptf64]
topologies: [t0, t0-64, t0-64-32, t0-116, t1, t1-lag, t1-64-lag, ptf32, ptf64]

ntp:
filename: ntp.yml
Expand Down