Skip to content

Fix ansible variable VM_targets undefined issue for ptf topology #4229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangxin merged 1 commit into from
Sep 12, 2021
Merged

Fix ansible variable VM_targets undefined issue for ptf topology #4229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ansible/roles/vm_set/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
home_path: "{{ getent_passwd[ansible_user][4] }}"
when: home_path is not defined

# root_path is supposed to be absolute path.
# root_path is supposed to be absolute path.
- set_fact:
root_path: "{{ home_path + '/' + root_path }}"
when: "not '{{ root_path }}'.startswith('/')"
Expand Down Expand Up @@ -265,6 +265,10 @@
set_fact: VM_targets={{ VM_hosts | filter_vm_targets(topology['VMs'], VM_base) | sort }}
when: topology['VMs'] is defined

- name: Set fallback default value for VM_targets
set_fact: VM_targets={{ [] }}
when: VM_targets is not defined

- name: Set vm configuration properties when configuration is defined
set_fact: vm_properties="{{ configuration | expand_properties(configuration_properties) }}"
when: configuration is defined
Expand Down