Skip to content

Added fix for ptf topo creation #4220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SavchukRomanLv wants to merge 1 commit into from
Closed

Added fix for ptf topo creation #4220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ansible/roles/vm_set/tasks/add_topo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,11 @@
- include_tasks: add_ceos_list.yml
when: vm_type is defined and vm_type == "ceos"

- name: Set VM_targets to empty string for ptf topologies
set_fact:
VM_targets: ""
when: topo | search("ptf")
Copy link
Copy Markdown
Contributor

@neethajohn neethajohn Sep 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when: 'ptf' in topo instead of using the search filter

Copy link
Copy Markdown
Author

@SavchukRomanLv SavchukRomanLv Sep 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neethajohn do you have any concerns about using search or some advantage? Thank you.

Copy link
Copy Markdown
Contributor

@neethajohn neethajohn Sep 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

came across threads that mentioned a deprecation warning for this usage. Hence the suggestion


- name: Bind topology {{ topo }} to VMs. base vm = {{ VM_base }}
vm_topology:
cmd: "bind"
Expand Down