Skip to content

[Mellanox] Modify AbnormalFanMocker check_result return value #4190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nhe-NV wants to merge 3 commits into from
Closed

[Mellanox] Modify AbnormalFanMocker check_result return value #4190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3531656
Add some testcase in the testcase.yml file
nhe-NV Aug 18, 2021
100a515
Merge remote branch 'upstream/master' into add_testcases
nhe-NV Sep 7, 2021
f4feb98
Modify AbnormalFanMocker check_result return value
nhe-NV Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ansible/roles/test/vars/testcases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ testcases:

reboot:
filename: reboot.yml
topologies: [t0, t0-52, t0-56, t0-64, t0-64-32, t0-116, t0-120, t1, t1-lag, t1-64-lag, t1-64-lag-clet, ptf32, ptf64]
topologies: [t0, t0-52, t0-56, t0-64, t0-64-32, t0-116, t0-120, t1, t1-lag, t1-64-lag, t1-64-lag-clet, ptf32, ptf64, ptf-any]

repeat_harness:
filename: repeat_harness.yml
Expand All @@ -280,7 +280,7 @@ testcases:
sensors:
filename: sensors_check.yml
vtestbed_compatible: no
topologies: [t0, t0-52, t0-56, t0-64, t0-64-32, t0-116, t0-120, t1, t1-lag, t1-64-lag, t1-64-lag-clet, ptf32, ptf64]
topologies: [t0, t0-52, t0-56, t0-64, t0-64-32, t0-116, t0-120, t1, t1-lag, t1-64-lag, t1-64-lag-clet, ptf32, ptf64, ptf-any]

service_acl:
filename: service_acl.yml
Expand Down Expand Up @@ -352,3 +352,7 @@ testcases:
read_mac:
filename: read_mac_metadata.yml
topologies: [t0, t1, t1-lag]

port_mirroring:
filename: test_port_mirroring.py
topologies: [t0]
7 changes: 4 additions & 3 deletions tests/platform_tests/mellanox/mellanox_thermal_control_test_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,9 +1008,10 @@ def check_result(self, actual_data):
self.expect_led_color)
except SysfsNotExistError as e:
logging.info('LED check only support on SPC2 and SPC3: {}'.format(e))
return

assert 0, 'Expected data not found'
return True

logging.error('Expected data not found')
return False

def is_fan_removable(self):
"""
Expand Down