Fix AttributeError exception seen when testing 201911 image.#4178
Merged
yxieca merged 1 commit intosonic-net:masterfrom Sep 8, 2021
Merged
Fix AttributeError exception seen when testing 201911 image.#4178yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
201911 does not require loading of database config. Add the right exception so that the exception of load db config can be ignored for 201911 image. Signed-off-by: Suvarna Meenakshi <[email protected]>
arlakshm
approved these changes
Sep 3, 2021
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Sep 8, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…et#4178) 201911 does not require loading of database config. Add the right exception so that the exception of load db config can be ignored for 201911 image. Signed-off-by: Suvarna Meenakshi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
201911 does not require loading of database config.
Add the right exception so that the exception of load db
config can be ignored for 201911 image.
Signed-off-by: Suvarna Meenakshi [email protected]
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
After #4112 fix to load database config, testing 201911 image causes an AttributeError:
line 68, in get_po_names\r\n File "/tmp/ansible_lag_facts_payload_eqDCQY/ansible_lag_facts_payload.zip/ansible/module_utils/multi_asic_utils.py", line 15, in load_db_config\r\nAttributeError: type object 'SonicDBConfig' has no attribute 'load_sonic_global_db_config'\r\n"
How did you do it?
Add exception handler.
How did you verify/test it?
Run tests in multi-asic VS 20911 image and ensure the error is not seen.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation