Skip to content

[topology]: Fix t1-64-lag topology device link base indices #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stcheng merged 1 commit into from
Jan 5, 2018
Merged

[topology]: Fix t1-64-lag topology device link base indices #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ansible/templates/topo/t1-64-lag.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,35 +324,35 @@
<ElementType>DeviceInterfaceLink</ElementType>
<EndDevice>{{ inventory_hostname }}</EndDevice>
<EndPort>{{ port_alias[32+index*8+2] }}</EndPort>
<StartDevice>ARISTA{{ '%02d' % (index+1) }}T0</StartDevice>
<StartDevice>ARISTA{{ '%02d' % (index*5+1) }}T0</StartDevice>
Copy link
Contributor

@lguohan lguohan Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 5 magic number?

Copy link
Contributor Author

@stcheng stcheng Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

@stcheng stcheng Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in total there are 20 T0 devices connected. we have four groups of links and each of the group has five up links.

<StartPort>Ethernet1</StartPort>
</DeviceLinkBase>
<DeviceLinkBase>
<ElementType>DeviceInterfaceLink</ElementType>
<EndDevice>{{ inventory_hostname }}</EndDevice>
<EndPort>{{ port_alias[32+index*8+2] }}</EndPort>
<StartDevice>ARISTA{{ '%02d' % (index+1) }}T0</StartDevice>
<EndPort>{{ port_alias[32+index*8+4] }}</EndPort>
<StartDevice>ARISTA{{ '%02d' % (index*5+2) }}T0</StartDevice>
<StartPort>Ethernet1</StartPort>
</DeviceLinkBase>
<DeviceLinkBase>
<ElementType>DeviceInterfaceLink</ElementType>
<EndDevice>{{ inventory_hostname }}</EndDevice>
<EndPort>{{ port_alias[32+index*8+5] }}</EndPort>
<StartDevice>ARISTA{{ '%02d' % (index+1) }}T0</StartDevice>
<StartDevice>ARISTA{{ '%02d' % (index*5+3) }}T0</StartDevice>
<StartPort>Ethernet1</StartPort>
</DeviceLinkBase>
<DeviceLinkBase>
<ElementType>DeviceInterfaceLink</ElementType>
<EndDevice>{{ inventory_hostname }}</EndDevice>
<EndPort>{{ port_alias[32+index*8+6] }}</EndPort>
<StartDevice>ARISTA{{ '%02d' % (index+1) }}T0</StartDevice>
<StartDevice>ARISTA{{ '%02d' % (index*5+4) }}T0</StartDevice>
<StartPort>Ethernet1</StartPort>
</DeviceLinkBase>
<DeviceLinkBase>
<ElementType>DeviceInterfaceLink</ElementType>
<EndDevice>{{ inventory_hostname }}</EndDevice>
<EndPort>{{ port_alias[32+index*8+7] }}</EndPort>
<StartDevice>ARISTA{{ '%02d' % (index+1) }}T0</StartDevice>
<StartDevice>ARISTA{{ '%02d' % (index*5+5) }}T0</StartDevice>
<StartPort>Ethernet1</StartPort>
</DeviceLinkBase>
{% endfor %}
Expand Down