[ansible] fix duplicate docker repository#4086
Merged
Xichen96 merged 1 commit intosonic-net:masterfrom Aug 25, 2021
Merged
Conversation
* fix problem where too many docker repo added Signed-off-by: Xichen Lin <xichenlin@microsoft.com>
Xichen96
changed the title
Xichen96
changed the title
Blueve
reviewed
Aug 20, 2021
Blueve
approved these changes
Aug 23, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
* fix problem where too many docker repo added Signed-off-by: Xichen Lin <xichenlin@microsoft.com> Co-authored-by: Xichen Lin <xichenlin@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xichen Lin xichenlin@microsoft.com
Description of PR
Summary:
In VsSetup, mgmt container will attempt to add docker repo, even though in this case a docker repo already exists, causing apt update failure.
Type of change
Back port request
Approach
What is the motivation for this PR?
Bug fix.
How did you do it?
Before installing new docker repo, ansible will check for files under /etc/apt/sources.list.d with name "docker" to avoid conflict.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation