Skip to content

[platform][test_auto_negotiation] Fix issue where the port selection exceed boundary #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Blueve merged 15 commits into from
Aug 24, 2021
Merged

[platform][test_auto_negotiation] Fix issue where the port selection exceed boundary #4055

Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c018241
[platform][test_auto_negotiation] Fix issue where the port selection …
Blueve Aug 17, 2021
d6d2457
Enumerate all ports for selecting candidaties
Blueve Aug 17, 2021
28a6dd5
Only do the sampling for DUT once
Blueve Aug 17, 2021
bbd3f34
Only do the sampling for DUT once
Blueve Aug 17, 2021
4507543
Refactor test
Blueve Aug 17, 2021
ffa1121
Skip test if fanout does not support setting auto-neg mode
Blueve Aug 18, 2021
7758296
Fix loop issue
Blueve Aug 18, 2021
0ef5bbb
Support new eos hardware command
Blueve Aug 18, 2021
414e0aa
Fix regex
Blueve Aug 18, 2021
c359fa7
Fix regex
Blueve Aug 18, 2021
1f204fd
Fix item index number
Blueve Aug 18, 2021
1e6f376
Fix loop issue
Blueve Aug 18, 2021
d790a35
Fix unpack issue
Blueve Aug 18, 2021
75a6aba
Fix LGMT alert
Blueve Aug 18, 2021
50520bb
Fix comments
Blueve Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/platform_tests/test_auto_negotiation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,11 @@ def recover_ports(duthosts, enum_dut_portname_module_fixture, fanouthosts):
logger.info('Collecting existing port configuration for DUT and fanout...')
for duthost in duthosts:
if dutname == 'unknown' or dutname == duthost.hostname:
all_ports = build_test_candidates(duthost, fanouthosts, portname)
Copy link
Copy Markdown
Collaborator Author

@Blueve Blueve Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will get a list that contains only 1 port by this way.
If we want to enumerate all ports, we have to put "all_ports" in it parameter list.

all_ports = build_test_candidates(duthost, fanouthosts, 'all_ports')
all_ports_len = len(all_ports)
# Test all ports takes too much time (sometimes more than an hour),
# so we choose 3 ports randomly as the cadidates ports
cadidate_test_ports[duthost] = random.sample(all_ports, 3)
cadidate_test_ports[duthost] = random.sample(all_ports, 3 if all_ports_len > 3 else all_ports_len)
for _, fanout, fanout_port in cadidate_test_ports[duthost]:
auto_neg_mode = fanout.get_auto_negotiation_mode(fanout_port)
speed = fanout.get_speed(fanout_port)
Expand Down