Add ECN WRED configuration test#384
Merged
yxieca merged 1 commit intosonic-net:masterfrom Jan 31, 2018
Merged
Conversation
Contributor
Author
|
Requires sonic-net/sonic-buildimage#1226 to work properly on Mellanox switch |
yxieca
reviewed
Jan 24, 2018
yxieca
reviewed
Jan 24, 2018
ansible/roles/test/tasks/sonic.yml
Outdated
Collaborator
There was a problem hiding this comment.
Can you also add an access point of this test case in test by test name infrastructure?
I think you need to change following file:
- https://github.com/Azure/sonic-mgmt/blob/master/ansible/roles/test/vars/testcases.yml
This file organizes test cases in alphabetic order.You can following any existing test case as example.
Thanks,
Ying
yxieca
reviewed
Jan 24, 2018
Collaborator
There was a problem hiding this comment.
I am not sure if this is a big deal or not. But we do have some devices doesn't yet have qos config.
Failing test on a dut which doesn't have qos config seems to be too harsh?
Is there a way to early exit instead of failing the test?
Please don't spend too much time on this question. It is a very minor issue. I am ok with it not fixed.
yxieca
reviewed
Jan 24, 2018
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
The test looks pretty good to me.
A few minor issues has been noted. Please take a look.
andriymoroz-mlnx
force-pushed
the
wred_config_test
branch
from
15480d0 to
3b9366f
Compare
andriymoroz-mlnx
changed the title
Signed-off-by: Andriy Moroz <[email protected]>
andriymoroz-mlnx
force-pushed
the
wred_config_test
branch
from
3b9366f to
cc00eed
Compare
yxieca
approved these changes
Jan 31, 2018
yxieca
approved these changes
Jan 31, 2018
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Jun 14, 2025
…os (sonic-net#384) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? The ansible-playbook checks container's reachability on the wrong host. If the number of neighbors is large, it can waste a lot of time. #### How did you do it? Fix the wrong host from ansible executing host to container host. #### How did you verify/test it? Check it locally. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Moroz [email protected]
Description of PR
Tests for the QoS/ECN configuration and ecnconfig utility
Type of change
Approach
How did you verify/test it?
ansible-playbook test_sonic.yml -i inventory --limit {DUT_NAME} --become --tags ecn_wredAny platform specific information?
Platform independent. Requires SAI support set for ECN/WRED parameters
Supported testbed topology if it's a new test case?
Topology independent
Documentation
Test plan:
QoS configuration in Config DB. ECN WRED configuration utility test plan