added EOS fanouts support for port autoneg tests#3823
Merged
lguohan merged 2 commits intosonic-net:masterfrom Aug 13, 2021
Merged
added EOS fanouts support for port autoneg tests#3823lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
|
This pull request introduces 3 alerts when merging dbba55e into ff76eb9 - view on LGTM.com new alerts:
|
lguohan
approved these changes
Aug 13, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Summary: added EOS fanouts support for port autoneg tests Fixes # (issue) implemented autoneg related management methods for EOS fanout Port autoneg setup is required on both sides, per cable connection, so tests use a fanout as neighbor for DUT to establish autoneg with. Interaction with a fanout rely on per OS specific implementation and some methods required by tests were missing for EOS. Implemented those methods
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…atically (sonic-net#22232) #### Why I did it src/sonic-utilities ``` * a6fcf564 - (HEAD -> 202411, origin/202411) [show][interfaces] Add proposal for show interfaces flap (sonic-net#3627) (sonic-net#3823) (8 hours ago) [vdahiya12] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: added EOS fanouts support for port autoneg tests
Fixes # (issue)
Port autoneg setup is required on both sides, per cable connection, so tests use a fanout as neighbor for DUT to establish autoneg with. Interaction with a fanout rely on per OS specific implementation and some methods required by tests were missing for EOS. Implemented those methods
Type of change
Back port request
Approach
What is the motivation for this PR?
Adapt port autoneg tests to work with EOS fanouts
How did you do it?
Implemented missing methods for autoneg management on EOS fanout switch
How did you verify/test it?
py.test --inventory=../ansible/lab,../ansible/veos --testbed_file=../ansible/testbed.csv --module-path=../ansible/library -v -rA --topology=t1,any platform_tests/test_auto_negotiation.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation