Improve robustness of test_bgp_allow_list#3488
Merged
wangxin merged 2 commits intosonic-net:masterfrom May 20, 2021
Merged
Conversation
BGP monitor is configured during BGP allow list and BGP monitor testing. The BGP monitor configuration includes adding new IP to PTF and DUT. In case the test script failed unexpectedly, the IP addresses added to PTF and DUT may not be cleaned. Then subsequent execution of BGP monitor and allow list may fail because of conflicting configurations on PTF and DUT. Changes to improve the robustness: * Before configure BGP monitor, always try to cleanup possible conflicting IP address configurations on PTF and DUT. * Replace fixed sleep with wait_until during check BGP monitor dumps. * Return list of routes not found in BGP monitor, not just a boolean value. * Added methods "change_mac_addresses" and "remove_ip_addresses" to class PTFHost. * Updated fixtures in ptfhost_utils.py to use the new PTFHost methods. Signed-off-by: Xin Wang <[email protected]>
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
BGP monitor is configured during BGP allow list and BGP monitor testing. The BGP monitor configuration includes adding new IP to PTF and DUT. In case the test script failed unexpectedly, the IP addresses added to PTF and DUT may not be cleaned. Then subsequent execution of BGP monitor and allow list may fail because of conflicting configurations on PTF and DUT. Changes to improve the robustness: * Before configure BGP monitor, always try to cleanup possible conflicting IP address configurations on PTF and DUT. * Replace fixed sleep with wait_until during check BGP monitor dumps. * Return list of routes not found in BGP monitor, not just a boolean value. * Added methods "change_mac_addresses" and "remove_ip_addresses" to class PTFHost. * Updated fixtures in ptfhost_utils.py to use the new PTFHost methods. Signed-off-by: Xin Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
BGP monitor is configured during BGP allow list and BGP monitor testing. The BGP
monitor configuration includes adding new IP to PTF and DUT. In case the test script
failed unexpectedly, the IP addresses added to PTF and DUT may not be cleaned.
Then subsequent execution of BGP monitor and allow list may fail because of conflicting
configurations on PTF and DUT.
How did you do it?
Changes to improve the robustness:
configurations on PTF and DUT.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation