Fix errors in deploying dualtor-120.#3359
Merged
bingwang-ms merged 4 commits intosonic-net:masterfrom May 31, 2021
Merged
Conversation
Signed-off-by: bingwang <bingwang@microsoft.com>
yxieca
reviewed
Apr 19, 2021
| # As a result, interface name like 'inje-vms21-6-132' will be invalid and rejected by kernel. | ||
| # Therefore, the name template is shorten to 3 bytes to contain more digits (3 in max) | ||
| INJECTED_INTERFACES_TEMPLATE = 'inj-%s-%d' | ||
| MUXY_INTERFACES_TEMPLATE = 'mux-%s-%d' |
Collaborator
There was a problem hiding this comment.
This is a disruptive change. This change will cause interface name change, so testbed deployed before this change cannot be removed after.
How do we deal with that?
Collaborator
Author
There was a problem hiding this comment.
Thanks for the good catch. I also noticed that some other components that depend on the interface name or bridge name will fail.
Signed-off-by: bingwang <bingwang@microsoft.com>
Collaborator
Author
|
Update. I implemented an |
lolyu
approved these changes
Apr 20, 2021
3 tasks
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
May 31, 2021
3 tasks
4 tasks
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Adaptive interface/bridge name. Signed-off-by: bingwang <bingwang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
This PR fixed several errors detected when deploying
dualtor-120.dualtor-120inansible/veosandansible/veos_vtbtopologyforvm_topologylibrary.Type of change
Approach
What is the motivation for this PR?
This PR is to fix errors detected when deploying dualtor-120.
How did you do it?
Please see code.
How did you verify/test it?
Verified by deploying the newly defined
dualtor-120.Any platform specific information?
No.
Supported testbed topology if it's a new test case?
No.
Documentation