Add "verbose" option for suppressing unnecessary log#3087
Merged
wangxin merged 1 commit intosonic-net:masterfrom Mar 10, 2021
wangxin:verbose-option
Merged
Add "verbose" option for suppressing unnecessary log#3087wangxin merged 1 commit intosonic-net:masterfrom wangxin:verbose-option
wangxin merged 1 commit intosonic-net:masterfrom
wangxin:verbose-option
Conversation
When execute an ansible module, the detailed arguments and module result are logged at DEBUG level by default. Sometimes, the module result could be too huge to be logged even at DEBUG level. This change added keyword option "verbose" to the method in AnsibleHostBase class for executing ansible modules. Default value of "verbose" is "True". If "verbose" is set to "False", only simplified messages will be logged at DEBUG level. This change also updated some test scripts and the sanity check scripts to use this option. Signed-off-by: Xin Wang <[email protected]>
bingwang-ms
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
When execute an ansible module, the detailed arguments and module result are logged
at DEBUG level by default. Sometimes, the module result could be too huge to be logged
even at DEBUG level.
How did you do it?
This change added keyword option "verbose" to the method in AnsibleHostBase class
for executing ansible modules. Default value of "verbose" is "True". If "verbose" is set to
"False", only simplified messages will be logged at DEBUG level. This change also updated
some test scripts and the sanity check scripts to use this option.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation